Attachment 7858 Details for Bug 9135 – v3-6-test patch

[patch] v3-6-test patch

0001-s3-winbind-DON-T-PANIC-if-we-couldn-t-find-the-domai.patch (text/plain), 1.25 KB, created by Andreas Schneider on 2012-09-04 13:15:58 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andreas Schneider

Created: 2012-09-04 13:15:58 UTC

Size: 1.25 KB

patch

obsolete

>From 7f3b738d5ebfd3e5f0445e4b26c55728a290b2d0 Mon Sep 17 00:00:00 2001
>From: Andreas Schneider <asn@samba.org>
>Date: Tue, 4 Sep 2012 14:30:38 +0200
>Subject: [PATCH] s3-winbind: DON'T PANIC if we couldn't find the domain.
>
>If we don't have a connection to a trusted domain but still try to do a
>lookup we shouldn't segfault.
>
>Signed-off-by: Andreas Schneider <asn@samba.org>
>---
> source3/winbindd/winbindd_group.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
>diff --git a/source3/winbindd/winbindd_group.c b/source3/winbindd/winbindd_group.c
>index 9cc1d14..8662a9c 100644
>--- a/source3/winbindd/winbindd_group.c
>+++ b/source3/winbindd/winbindd_group.c
>@@ -35,9 +35,17 @@ bool fill_grent(TALLOC_CTX *mem_ctx, struct winbindd_gr *gr,
> {
> 	fstring full_group_name;
> 	char *mapped_name = NULL;
>-	struct winbindd_domain *domain = find_domain_from_name_noinit(dom_name);
>+	struct winbindd_domain *domain;
> 	NTSTATUS nt_status = NT_STATUS_UNSUCCESSFUL;
> 
>+	domain = find_domain_from_name_noinit(dom_name);
>+	if (domain == NULL) {
>+		DEBUG(0, ("Failed to find domain '%s'. "
>+			  "Check connection to trusted domains!\n",
>+			  dom_name));
>+		return false;
>+	}
>+
> 	nt_status = normalize_name_map(mem_ctx, domain, gr_name,
> 				       &mapped_name);
> 
>-- 
>1.7.11.5
>

Flags:

asn: review? (jra)
gd: review+

Actions: View

Attachments on bug 9135: 7858