From 823e745a12be2fe1c1c8e214958602d31103a645 Mon Sep 17 00:00:00 2001 From: David Disseldorp Date: Tue, 28 Aug 2012 18:58:24 +0200 Subject: [PATCH] s3-printing: fix bug 9123 lprng job tracking errors The lprng printing back-end is truncating the print job filename in the lpq output, which means that Samba is not able to determine the back-end job ID for a newly submitted print job. Remove the unneeded spoolss job ID from the print job file name to ensure the job filename is not truncated. Also log these warnings at a higher log level. --- source3/printing/print_generic.c | 2 +- source3/printing/printing.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/source3/printing/print_generic.c b/source3/printing/print_generic.c index aac3892..7a7cd3b 100644 --- a/source3/printing/print_generic.c +++ b/source3/printing/print_generic.c @@ -288,7 +288,7 @@ static int generic_job_submit(int snum, struct printjob *pjob, ret = 0; } if (pjob->sysjob == -1) { - DEBUG(0, ("failed to get sysjob for job %u (%s), tracking as " + DEBUG(2, ("failed to get sysjob for job %u (%s), tracking as " "Unix job\n", pjob->jobid, jobname)); } diff --git a/source3/printing/printing.c b/source3/printing/printing.c index aa5b41d..ba73918 100644 --- a/source3/printing/printing.c +++ b/source3/printing/printing.c @@ -2843,8 +2843,7 @@ static WERROR print_job_spool_file(int snum, uint32_t jobid, } slprintf(pjob->filename, sizeof(pjob->filename)-1, - "%s/%s%.8u.XXXXXX", lp_pathname(snum), - PRINT_SPOOL_PREFIX, (unsigned int)jobid); + "%s/%sXXXXXX", lp_pathname(snum), PRINT_SPOOL_PREFIX); pjob->fd = mkstemp(pjob->filename); if (pjob->fd == -1) { -- 1.7.1