Attachment 7653 Details for Bug 9000 – patch for samba-3.5.15

[patch] patch for samba-3.5.15

samba-3.5.15-avoid_circularly_list.patch (text/plain), 1.02 KB, created by Tsukasa HAMANO on 2012-06-18 04:51:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tsukasa HAMANO

Created: 2012-06-18 04:51:38 UTC

Size: 1.02 KB

patch

obsolete

>diff --git a/source3/winbindd/winbindd_dual.c b/source3/winbindd/winbindd_dual.c
>index 360f1b2..ebda52a 100644
>--- a/source3/winbindd/winbindd_dual.c
>+++ b/source3/winbindd/winbindd_dual.c
>@@ -1305,6 +1305,7 @@ static bool fork_domain_child(struct winbindd_child *child)
> 	struct winbindd_request request;
> 	struct winbindd_response response;
> 	struct winbindd_domain *primary_domain = NULL;
>+	struct winbindd_child *c;
> 
> 	if (child->domain) {
> 		DEBUG(10, ("fork_domain_child called for domain '%s'\n",
>@@ -1336,8 +1337,18 @@ static bool fork_domain_child(struct winbindd_child *child)
> 		/* Parent */
> 		close(fdpair[0]);
> 		child->next = child->prev = NULL;
>-		DLIST_ADD(children, child);
> 		child->sock = fdpair[1];
>+		/*
>+		 * We need to check duplicate element before
>+		 * DLIST_ADD. Otherwise, childlen list be circularly.
>+		 */
>+		for (c = children; c != NULL; c = child->next) {
>+			if (c == child) {
>+				DEBUG(5, ("Already added child in children\n");
>+				return True;
>+			}
>+		}
>+		DLIST_ADD(children, child);
> 		return True;
> 	}
>

Actions: View

Attachments on bug 9000: 7653 | 7654 | 7655 | 7658