Attachment 7647 Details for Bug 8989 – git am fix for 3.6.next and 3.5.next.

[patch] git am fix for 3.6.next and 3.5.next.

0001-Fix-Bug-8989-Samba-3.5.x-and-probably-all-other-vers.patch (text/plain), 1.12 KB, created by Jeremy Allison on 2012-06-14 21:55:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jeremy Allison

Created: 2012-06-14 21:55:23 UTC

Size: 1.12 KB

patch

obsolete

>From 1dc30f06afc508c757f094d30f9f674ee8f62c28 Mon Sep 17 00:00:00 2001
>From: Jeremy Allison <jra@samba.org>
>Date: Thu, 14 Jun 2012 14:53:18 -0700
>Subject: [PATCH] Fix Bug 8989 - Samba 3.5.x (and probably all other versions
> of Samba) does not send correct responses to NT Transact
> Secondary when no data and no params
>
>Found by Richard Sharpe <realrichardsharpe@gmail.com>. The correct
>command code in a reply to NT Transact Secondary (0xa1) is
>NT Transact (0xa0).
>---
> source3/smbd/nttrans.c |    6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
>diff --git a/source3/smbd/nttrans.c b/source3/smbd/nttrans.c
>index 429250e..47a3747 100644
>--- a/source3/smbd/nttrans.c
>+++ b/source3/smbd/nttrans.c
>@@ -3255,6 +3255,12 @@ void reply_nttranss(struct smb_request *req)
> 
> 	show_msg((char *)req->inbuf);
> 
>+	/* Windows clients expect all replies to
>+	   an NT transact secondary (SMBnttranss 0xA1)
>+	   to have a command code of NT transact
>+	   (SMBnttrans 0xA0). See bug #8989 for details. */
>+	req->cmd = SMBnttrans;
>+
> 	if (req->wct < 18) {
> 		reply_nterror(req, NT_STATUS_INVALID_PARAMETER);
> 		END_PROFILE(SMBnttranss);
>-- 
>1.7.7.3
>

Actions: View

Attachments on bug 8989: 7634 | 7635 | 7636 | 7647 | 7648 | 7660