Attachment 7611 Details for Bug 8910 – Additional fix for 3.6.next.

[patch] Additional fix for 3.6.next.

0001-Fix-bad-bugfix-for-bug-8910-resolve_ads-code-can-ret.patch (text/plain), 1.15 KB, created by Jeremy Allison on 2012-05-30 21:34:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jeremy Allison

Created: 2012-05-30 21:34:36 UTC

Size: 1.15 KB

patch

obsolete

>From e4e3aecea69a9ee351cd7b385f9ce851305446b4 Mon Sep 17 00:00:00 2001
>From: Ira Cooper <ira@wakeful.net>
>Date: Wed, 30 May 2012 11:50:06 -0700
>Subject: [PATCH] Fix bad bugfix for bug #8910 - resolve_ads() code can return
> zero addresses and miss valid DC IP addresses
>
>Original code incorrectly used a while() instead of a for() loop.
>We need to iterate over the entire array here.
>
>Autobuild-User: Jeremy Allison <jra@samba.org>
>Autobuild-Date: Wed May 30 23:29:03 CEST 2012 on sn-devel-104
>(cherry picked from commit fc7e1113c34819de6fc8053fb81ee2e0e970bec2)
>---
> source3/libsmb/namequery.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/source3/libsmb/namequery.c b/source3/libsmb/namequery.c
>index d0ab62f..4ba7204 100644
>--- a/source3/libsmb/namequery.c
>+++ b/source3/libsmb/namequery.c
>@@ -1934,7 +1934,7 @@ static NTSTATUS resolve_ads(const char *name,
> 
> 	*return_count = 0;
> 
>-	while ( i < numdcs && (*return_count<numaddrs) ) {
>+	for (i = 0; i < numdcs && (*return_count<numaddrs); i++ ) {
> 		/* If we don't have an IP list for a name, lookup it up */
> 		if (!dcs[i].ss_s) {
> 			/* We need to get all IP addresses here. */
>-- 
>1.7.7.3
>

Flags:

ira: review+

Actions: View

Attachments on bug 8910: 7510 | 7511 | 7609 | 7610 | 7611