Attachment 7593 Details for Bug 8952 – Fix for master.

[patch] Fix for master.

0001-s3-passdb-Fix-negative-SID-uid-gid-both-cache-handli.patch (text/plain), 987 bytes, created by Ira Cooper on 2012-05-24 12:34:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ira Cooper

Created: 2012-05-24 12:34:39 UTC

Size: 987 bytes

patch

obsolete

>From be434af1580ba95715786430c995d3afc50ea479 Mon Sep 17 00:00:00 2001
>From: Ira Cooper <ira@samba.org>
>Date: Wed, 23 May 2012 21:42:26 -0400
>Subject: [PATCH] s3-passdb: Fix negative SID->uid/gid/both cache handling
>
>-1 uid/gid/both signals a non existent uid/gid/both.
>---
> source3/passdb/lookup_sid.c |   14 ++++++++++++++
> 1 files changed, 14 insertions(+), 0 deletions(-)
>
>diff --git a/source3/passdb/lookup_sid.c b/source3/passdb/lookup_sid.c
>index 4ceba3c..96e65e9 100644
>--- a/source3/passdb/lookup_sid.c
>+++ b/source3/passdb/lookup_sid.c
>@@ -1347,6 +1347,20 @@ bool sids_to_unixids(const struct dom_sid *sids, uint32_t num_sids,
> 		}
> 	}
> done:
>+	for (i=0; i<num_sids; i++) {
>+		switch(ids[i].type) {
>+		case WBC_ID_TYPE_GID:
>+		case WBC_ID_TYPE_UID:
>+		case WBC_ID_TYPE_BOTH:
>+			if (ids[i].id == -1) {
>+				ids[i].type = ID_TYPE_NOT_SPECIFIED;
>+			}
>+			break;
>+		case WBC_ID_TYPE_NOT_SPECIFIED:
>+			break;
>+		}
>+	}
>+			
> 	ret = true;
> fail:
> 	TALLOC_FREE(wbc_ids);
>-- 
>1.7.1
>

Flags:

metze: review+

Actions: View

Attachments on bug 8952: 7575 | 7576 | 7577 | 7578 | 7579 | 7580 | 7586 | 7587 | 7590 | 7591 | 7592 | 7593