Attachment 7592 Details for Bug 8952 – Patch for v3-6-test

[patch] Patch for v3-6-test

tmp36.diff (text/plain), 1.12 KB, created by Stefan Metzmacher on 2012-05-24 12:05:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Stefan Metzmacher

Created: 2012-05-24 12:05:32 UTC

Size: 1.12 KB

patch

obsolete

>From 7a64da3189a1e901aff66aa5e2e46e4a9c03750f Mon Sep 17 00:00:00 2001
>From: Ira Cooper <ira@samba.org>
>Date: Wed, 23 May 2012 21:39:03 -0400
>Subject: [PATCH] s3-passdb: Fix negative SID->uid/gid cache handling. (bug #8952)
>
>-1 uid/gid signals a non existent uid/gid.
>
>Signed-off-by: Stefan Metzmacher <metze@samba.org>
>---
> source3/passdb/lookup_sid.c |   17 +++++++++++++++++
> 1 files changed, 17 insertions(+), 0 deletions(-)
>
>diff --git a/source3/passdb/lookup_sid.c b/source3/passdb/lookup_sid.c
>index 5cf391f..2afa86e 100644
>--- a/source3/passdb/lookup_sid.c
>+++ b/source3/passdb/lookup_sid.c
>@@ -1490,7 +1490,24 @@ bool sids_to_unix_ids(const struct dom_sid *sids, uint32_t num_sids,
> 			continue;
> 		}
> 	}
>+
> done:
>+	for (i=0; i<num_sids; i++) {
>+		switch(ids[i].type) {
>+		case WBC_ID_TYPE_GID:
>+			if (ids[i].id.gid == (gid_t)-1) {
>+				ids[i].type = WBC_ID_TYPE_NOT_SPECIFIED;
>+			}
>+			break;
>+		case WBC_ID_TYPE_UID:
>+			if (ids[i].id.uid == (uid_t)-1) {
>+				ids[i].type = WBC_ID_TYPE_NOT_SPECIFIED;
>+			}
>+			break;
>+		case WBC_ID_TYPE_NOT_SPECIFIED:
>+			break;
>+		}
>+	}
> 	ret = true;
> fail:
> 	TALLOC_FREE(wbc_ids);
>-- 
>1.7.4.1
>

Flags:

ira: review+

Actions: View

Attachments on bug 8952: 7575 | 7576 | 7577 | 7578 | 7579 | 7580 | 7586 | 7587 | 7590 | 7591 | 7592 | 7593