Attachment 7539 Details for Bug 8920 – fix

[patch] fix

8920.patch (text/plain), 1.40 KB, created by Volker Lendecke on 2012-05-09 12:27:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Volker Lendecke

Created: 2012-05-09 12:27:12 UTC

Size: 1.40 KB

patch

obsolete

>From c4782cb48feb2e9409d6e51e33038c41768ad06e Mon Sep 17 00:00:00 2001
>From: Steve Langasek <steve.langasek@ubuntu.com>
>Date: Wed, 9 May 2012 07:56:00 +0200
>Subject: [PATCH] Fix bug 8920, null dereference
>
>Description: Avoid null dereference in initialize_password_db()
> When initialize_password_db() is called with reload=True, it's assumed that
> the free_private_data member of pdb_methods is non-null.  This is not
> necessarily the case, as the tdb backend has no private data and therefore
> no free function.  Check to see if we have private data that needs freed
> before calling.
>Author: Steve Langasek <steve.langasek@ubuntu.com>
>Bug-Ubuntu: https://bugs.launchpad.net/bugs/829221
>---
> source3/passdb/pdb_interface.c |    4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
>diff --git a/source3/passdb/pdb_interface.c b/source3/passdb/pdb_interface.c
>index 36d5aaa..3c11016 100644
>--- a/source3/passdb/pdb_interface.c
>+++ b/source3/passdb/pdb_interface.c
>@@ -184,7 +184,9 @@ static struct pdb_methods *pdb_get_methods_reload( bool reload )
> 	static struct pdb_methods *pdb = NULL;
> 
> 	if ( pdb && reload ) {
>-		pdb->free_private_data( &(pdb->private_data) );
>+		if (pdb->free_private_data != NULL) {
>+			pdb->free_private_data( &(pdb->private_data) );
>+		}
> 		if ( !NT_STATUS_IS_OK( make_pdb_method_name( &pdb, lp_passdb_backend() ) ) ) {
> 			char *msg = NULL;
> 			if (asprintf(&msg, "pdb_get_methods_reload: "
>-- 
>1.7.5.4
>

Flags:

obnox: review+

Actions: View

Attachments on bug 8920: 7533 | 7539