Attachment 7346 Details for Bug 8771 – Clean patch that applies to 3.5.x branch

[patch] Clean patch that applies to 3.5.x branch

0001-s3-winbindd-Close-netlogon-connection-if-the-status-_3.5.x.patch (text/plain), 1.36 KB, created by Matthieu Patou on 2012-02-24 23:15:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Matthieu Patou

Created: 2012-02-24 23:15:32 UTC

Size: 1.36 KB

patch

obsolete

>From cf76a9589c14d1694c4b492564b2f913341866d7 Mon Sep 17 00:00:00 2001
>From: Matthieu Patou <mat@matws.net>
>Date: Fri, 24 Feb 2012 14:06:02 -0800
>Subject: [PATCH] s3-winbindd: Close netlogon connection if the status
> returned by the NetrSamLogonEx call is timeout in the
> pam_auth_crap path
>
>If not the child process would hang for quite a long time up to the
>moment when the connection is cleaned by the kernel (took ~ 20 minutes)
>in my tests.
>---
> source3/winbindd/winbindd_pam.c |    9 +++++++++
> 1 files changed, 9 insertions(+), 0 deletions(-)
>
>diff --git a/source3/winbindd/winbindd_pam.c b/source3/winbindd/winbindd_pam.c
>index df1a868..a42e367 100644
>--- a/source3/winbindd/winbindd_pam.c
>+++ b/source3/winbindd/winbindd_pam.c
>@@ -2080,6 +2080,15 @@ enum winbindd_result winbindd_dual_pam_auth_crap(struct winbindd_domain *domain,
> 
> done:
> 
>+	if (NT_STATUS_EQUAL(result, NT_STATUS_IO_TIMEOUT)) {
>+		DEBUG(3,("winbindd_dual_pam_auth_crap: sam_network_logon(ex) "
>+				"returned NT_STATUS_IO_TIMEOUT after the retry."
>+				"We didn't know what's going on killing "
>+				"connections to domain %s\n",
>+				name_domain));
>+		invalidate_cm_connection(&contact_domain->conn);
>+	}
>+
> 	/* give us a more useful (more correct?) error code */
> 	if ((NT_STATUS_EQUAL(result, NT_STATUS_DOMAIN_CONTROLLER_NOT_FOUND) ||
> 	    (NT_STATUS_EQUAL(result, NT_STATUS_UNSUCCESSFUL)))) {
>-- 
>1.7.5.4
>

Flags:

jra: review+

Actions: View

Attachments on bug 8771: 7335 | 7336 | 7337 | 7345 | 7346 | 7347 | 7348