Attachment 7327 Details for Bug 8314 – patch for v3-5-test

[patch] patch for v3-5-test

samba-3.5.12-security_server.patch (text/plain), 1.73 KB, created by Guenther Deschner on 2012-02-16 13:20:58 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Guenther Deschner

Created: 2012-02-16 13:20:58 UTC

Size: 1.73 KB

patch

obsolete

>From af8398b9d32911e20fffe3d49310f7b9b92f2c45 Mon Sep 17 00:00:00 2001
>From: Jeremy Allison <jra@samba.org>
>Date: Fri, 22 Jul 2011 16:40:54 -0700
>Subject: [PATCH] Fix bug 8314] - smbd crash with unknown user.
>
>All other auth modules code with being called with
>auth_method->private_data being NULL, make the auth_server
>module cope with this too.
>
>Autobuild-User: Jeremy Allison <jra@samba.org>
>Autobuild-Date: Sat Jul 23 02:55:01 CEST 2011 on sn-devel-104
>(cherry picked from commit 1832c9591099be941ef3afe7b0381c4af61f4728)
>---
> source3/auth/auth_server.c |   15 ++++++++++++---
> 1 files changed, 12 insertions(+), 3 deletions(-)
>
>diff --git a/source3/auth/auth_server.c b/source3/auth/auth_server.c
>index 287b50b..bc38041 100644
>--- a/source3/auth/auth_server.c
>+++ b/source3/auth/auth_server.c
>@@ -273,14 +273,23 @@ static NTSTATUS check_smbserver_security(const struct auth_context *auth_context
> 					 const auth_usersupplied_info *user_info, 
> 					 auth_serversupplied_info **server_info)
> {
>-	struct server_security_state *state = talloc_get_type_abort(
>-		my_private_data, struct server_security_state);
>-	struct cli_state *cli;
>+	struct server_security_state *state = NULL;
>+	struct cli_state *cli = NULL;
> 	static bool tested_password_server = False;
> 	static bool bad_password_server = False;
> 	NTSTATUS nt_status = NT_STATUS_NOT_IMPLEMENTED;
> 	bool locally_made_cli = False;
> 
>+	DEBUG(10, ("check_smbserver_security: Check auth for: [%s]\n",
>+		user_info->smb_name));
>+
>+	if (my_private_data == NULL) {
>+		DEBUG(10,("check_smbserver_security: "
>+			"password server is not connected\n"));
>+		return NT_STATUS_LOGON_FAILURE;
>+	}
>+
>+	state = talloc_get_type_abort(my_private_data, struct server_security_state);
> 	cli = state->cli;
> 	
> 	if (cli) {
>-- 
>1.7.7.6
>

Flags:

ambi: review+

Actions: View

Attachments on bug 8314: 6712 | 7327