Attachment 7323 Details for Bug 8762 – fix based on v3-6-test

[patch] fix based on v3-6-test

0001-s3-printing-fix-crash-in-printer_list_set_printer.patch (text/plain), 1.08 KB, created by David Disseldorp on 2012-02-15 14:47:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Disseldorp

Created: 2012-02-15 14:47:27 UTC

Size: 1.08 KB

patch

obsolete

>From c882444f1bb0cd84d212ba245a47287c9d2f0477 Mon Sep 17 00:00:00 2001
>From: David Disseldorp <ddiss@samba.org>
>Date: Wed, 15 Feb 2012 16:30:27 +0100
>Subject: [PATCH] s3-printing: fix crash in printer_list_set_printer()
>
>The printer list database format was recently changed to accommodate for
>the printcap location field.
>One of the tdb_pack calls is not provided with a location string
>argument, this causes a crash on some platforms.
>
>https://bugzilla.samba.org/show_bug.cgi?id=8762
>---
> source3/printing/printer_list.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/source3/printing/printer_list.c b/source3/printing/printer_list.c
>index d28278d..6ddd774 100644
>--- a/source3/printing/printer_list.c
>+++ b/source3/printing/printer_list.c
>@@ -191,7 +191,7 @@ NTSTATUS printer_list_set_printer(TALLOC_CTX *mem_ctx,
> 	data.dsize = len;
> 
> 	len = tdb_pack(data.dptr, data.dsize,
>-		       PL_DATA_FORMAT, time_h, time_l, name, str);
>+		       PL_DATA_FORMAT, time_h, time_l, name, str, str2);
> 
> 	status = dbwrap_store_bystring_upper(db, key, data, TDB_REPLACE);
> 
>-- 
>1.7.7
>

Flags:

gd: review+

Actions: View

Attachments on bug 8762: 7323