Attachment 7302 Details for Bug 8747 – Backported Samba 4 patch

[patch] Backported Samba 4 patch

remove-prompter.patch (text/plain), 1.45 KB, created by Harry Mason on 2012-02-08 12:12:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Harry Mason

Created: 2012-02-08 12:12:49 UTC

Size: 1.45 KB

patch

obsolete

>Remove Kerberos password prompter which breaks when password expired
>
>Backport of 10989431e533bd60de242dbd78c4b62c4ace7812 to Samba 3:
>r11215: Remove no-op prompter intended to work around bugs in old kerberos libs.
>
>--- a/source3/libads/kerberos.c
>+++ b/source3/libads/kerberos.c
>@@ -34,33 +34,6 @@
> 
> #define LIBADS_CCACHE_NAME "MEMORY:libads"
> 
>-/*
>-  we use a prompter to avoid a crash bug in the kerberos libs when 
>-  dealing with empty passwords
>-  this prompter is just a string copy ...
>-*/
>-static krb5_error_code 
>-kerb_prompter(krb5_context ctx, void *data,
>-	       const char *name,
>-	       const char *banner,
>-	       int num_prompts,
>-	       krb5_prompt prompts[])
>-{
>-	if (num_prompts == 0) return 0;
>-
>-	memset(prompts[0].reply->data, '\0', prompts[0].reply->length);
>-	if (prompts[0].reply->length > 0) {
>-		if (data) {
>-			strncpy((char *)prompts[0].reply->data, (const char *)data,
>-				prompts[0].reply->length-1);
>-			prompts[0].reply->length = strlen((const char *)prompts[0].reply->data);
>-		} else {
>-			prompts[0].reply->length = 0;
>-		}
>-	}
>-	return 0;
>-}
>-
>  static bool smb_krb5_get_ntstatus_from_krb5_error(krb5_error *error,
> 						   NTSTATUS *nt_status)
> {
>@@ -224,7 +197,7 @@ int kerberos_kinit_password_ext(const char *principal,
> 	}
> 
> 	if ((code = krb5_get_init_creds_password(ctx, &my_creds, me, CONST_DISCARD(char *,password), 
>-						 kerb_prompter, CONST_DISCARD(char *,password),
>+						 NULL, NULL,
> 						 0, NULL, opt))) {
> 		goto out;
> 	}

Actions: View

Attachments on bug 8747: 7302