Attachment 7137 Details for Bug 8608 – v3-5-test patch4

[patch] v3-5-test patch4

0001-s3-winbind-Don-t-fail-on-users-without-a-uid.patch (text/plain), 1.90 KB, created by Andreas Schneider on 2011-11-22 12:01:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andreas Schneider

Created: 2011-11-22 12:01:57 UTC

Size: 1.90 KB

patch

obsolete

>From c7de39df4f4acfde19a08d3ca4687f3b8f1a28bc Mon Sep 17 00:00:00 2001
>From: Andreas Schneider <asn@samba.org>
>Date: Mon, 14 Nov 2011 10:01:31 +0100
>Subject: [PATCH] s3-winbind: Don't fail on users without a uid.
>
>This fixes bug #8608.
>
>If you join samba with idmap_ad backend to an AD. When you try to
>enumerate users with 'getent passwd' and the user doesn't have a uid
>set, then getent is aborted cause of NT_STATUS_NONE_MAPPED. If we can't
>map a user we should not stop but continue enumerating users.
>
>This normally happens with the default user 'krbtgt' with idmap_ad but
>could also happen with other backends.
>
>Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
>Autobuild-Date: Tue Nov 15 16:52:04 CET 2011 on sn-devel-104
>
>(backported from commit 10b285ccc29b106f164a6c18116e237634867717)
>
>Signed-off-by: Andreas Schneider <asn@samba.org>
>---
> source3/winbindd/wb_next_pwent.c |   19 ++++++++++++++++++-
> 1 files changed, 18 insertions(+), 1 deletions(-)
>
>diff --git a/source3/winbindd/wb_next_pwent.c b/source3/winbindd/wb_next_pwent.c
>index fbaaa48..e5b5e29 100644
>--- a/source3/winbindd/wb_next_pwent.c
>+++ b/source3/winbindd/wb_next_pwent.c
>@@ -147,7 +147,24 @@ static void wb_next_pwent_fill_done(struct tevent_req *subreq)
> 
> 	status = wb_fill_pwent_recv(subreq);
> 	TALLOC_FREE(subreq);
>-	if (!NT_STATUS_IS_OK(status)) {
>+	/*
>+	 * When you try to enumerate users with 'getent passwd' and the user
>+	 * doesn't have a uid set we should just move on.
>+	 */
>+	if (NT_STATUS_EQUAL(status, NT_STATUS_NONE_MAPPED)) {
>+		state->gstate->next_user += 1;
>+
>+		subreq = wb_fill_pwent_send(state,
>+					    state->ev,
>+					    &state->gstate->users[state->gstate->next_user],
>+					    state->pw);
>+		if (tevent_req_nomem(subreq, req)) {
>+			return;
>+		}
>+		tevent_req_set_callback(subreq, wb_next_pwent_fill_done, req);
>+
>+		return;
>+	} else if (!NT_STATUS_IS_OK(status)) {
> 		tevent_req_nterror(req, status);
> 		return;
> 	}
>-- 
>1.7.7.3
>

Flags:

vl: review+

Actions: View

Attachments on bug 8608: 7100 | 7101 | 7122 | 7123 | 7127 | 7136 | 7137