From b8dfb5dfa3c48d9f8c7304e6f210fa32d0eeb0ac Mon Sep 17 00:00:00 2001 From: Stefan Metzmacher Date: Thu, 10 Nov 2011 14:43:55 +0100 Subject: [PATCH] libcli/cldap: fix a crash bug in cldap_socket_recv_dgram() (bug #8593) After a calling any wrapper of tevent_req_notify_callback(), e.g. tevent_req_nterror(), tevent_req_done(), tevent_req_nomem(), a function has to return immediately otherwise it is very likely to crash. metze (similar to commit 17f1a97a614db4ed8292544988cb6a6cf56621d8) --- libcli/cldap/cldap.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/libcli/cldap/cldap.c b/libcli/cldap/cldap.c index 191d0ee..a01cbf8 100644 --- a/libcli/cldap/cldap.c +++ b/libcli/cldap/cldap.c @@ -278,6 +278,7 @@ nomem: error: status = map_nt_error_from_unix(in->recv_errno); nterror: + TALLOC_FREE(in); /* in connected mode the first pending search gets the error */ if (!c->connected) { /* otherwise we just ignore the error */ @@ -288,7 +289,7 @@ nterror: } tevent_req_nterror(c->searches.list->req, status); done: - talloc_free(in); + TALLOC_FREE(in); } /* -- 1.7.4.1