From 8a78c2bf1de644f965b424b83954639b9a982f70 Mon Sep 17 00:00:00 2001 From: David Disseldorp Date: Wed, 2 Nov 2011 18:39:03 +0100 Subject: [PATCH] pam_winbind: fix segfault in pam_sm_authenticate() Skip the cleanup path if context initialisation fails, the cleanup path dereferences the context pointer. https://bugzilla.samba.org/show_bug.cgi?id=8564 --- nsswitch/pam_winbind.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/nsswitch/pam_winbind.c b/nsswitch/pam_winbind.c index 0497726..d3b4faa 100644 --- a/nsswitch/pam_winbind.c +++ b/nsswitch/pam_winbind.c @@ -2598,7 +2598,7 @@ int pam_sm_authenticate(pam_handle_t *pamh, int flags, retval = _pam_winbind_init_context(pamh, flags, argc, argv, &ctx); if (retval) { - goto out; + return retval; } _PAM_LOG_FUNCTION_ENTER("pam_sm_authenticate", ctx); -- 1.7.3.4