The Samba-Bugzilla – Attachment 6927 Details for
Bug 8474
SMB2 create doesn't cope with an Apple client using NULL blob in create.
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
/tmp/look
look (text/plain), 818 bytes, created by
Jeremy Allison
on 2011-09-21 20:50:46 UTC
(
hide
)
Description:
/tmp/look
Filename:
MIME Type:
Creator:
Jeremy Allison
Created:
2011-09-21 20:50:46 UTC
Size:
818 bytes
patch
obsolete
>diff --git a/libcli/smb/smb2_create_blob.c b/libcli/smb/smb2_create_blob.c >index 444dc84..31c67e9 100644 >--- a/libcli/smb/smb2_create_blob.c >+++ b/libcli/smb/smb2_create_blob.c >@@ -63,9 +63,10 @@ NTSTATUS smb2_create_blob_parse(TALLOC_CTX *mem_ctx, const DATA_BLOB buffer, > name_offset > remaining || > name_length != 4 || /* windows enforces this */ > name_offset + name_length > remaining || >- data_offset < name_offset + name_length || >- data_offset > remaining || >- data_offset + (uint64_t)data_length > remaining) { >+ (data_offset && (data_offset < name_offset + name_length)) || >+ (data_offset && (data_offset > remaining)) || >+ (data_offset && data_length && >+ (data_offset + (uint64_t)data_length > remaining))) { > return NT_STATUS_INVALID_PARAMETER; > } >
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=6927">View the attachment on a separate page</a>.</b>
View Attachment As Raw
Flags:
metze
:
review+
Actions:
View
Attachments on
bug 8474
:
6927
|
6943
|
6944