Attachment 6897 Details for Bug 8455 – Patch

[patch] Patch

8455.patch (text/plain), 1.58 KB, created by Volker Lendecke on 2011-09-16 13:49:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Volker Lendecke

Created: 2011-09-16 13:49:55 UTC

Size: 1.58 KB

patch

obsolete

>From e61e160199f64291e996c82eba9a7fd71040be83 Mon Sep 17 00:00:00 2001
>From: Volker Lendecke <vl@samba.org>
>Date: Fri, 16 Sep 2011 15:45:47 +0200
>Subject: [PATCH] s3: Fix bug 8455 -- Samba PDC is looking up only primary user group
>
>group_sids_to_info3 does a sid_peek_check_rid on the domain sid before adding
>the rids to the array. If the domain sid is 0x0, then the check will always
>fail.
>---
> source3/auth/server_info.c |   14 +++++++-------
> 1 files changed, 7 insertions(+), 7 deletions(-)
>
>diff --git a/source3/auth/server_info.c b/source3/auth/server_info.c
>index dec99b6..fd21010 100644
>--- a/source3/auth/server_info.c
>+++ b/source3/auth/server_info.c
>@@ -428,6 +428,13 @@ NTSTATUS samu_to_SamInfo3(TALLOC_CTX *mem_ctx,
> 	info3->base.logon_count	= pdb_get_logon_count(samu);
> 	info3->base.bad_password_count = pdb_get_bad_password_count(samu);
> 
>+	info3->base.domain.string = talloc_strdup(info3,
>+						  pdb_get_domain(samu));
>+	RET_NOMEM(info3->base.domain.string);
>+
>+	info3->base.domain_sid = dom_sid_dup(info3, &domain_sid);
>+	RET_NOMEM(info3->base.domain_sid);
>+
> 	status = pdb_enum_group_memberships(mem_ctx, samu,
> 					    &group_sids, &gids,
> 					    &num_group_sids);
>@@ -458,13 +465,6 @@ NTSTATUS samu_to_SamInfo3(TALLOC_CTX *mem_ctx,
> 		RET_NOMEM(info3->base.logon_server.string);
> 	}
> 
>-	info3->base.domain.string = talloc_strdup(info3,
>-						  pdb_get_domain(samu));
>-	RET_NOMEM(info3->base.domain.string);
>-
>-	info3->base.domain_sid = dom_sid_dup(info3, &domain_sid);
>-	RET_NOMEM(info3->base.domain_sid);
>-
> 	info3->base.acct_flags = pdb_get_acct_ctrl(samu);
> 
> 	*_info3 = info3;
>-- 
>1.5.6.5
>

Flags:

idra: review+

Actions: View

Attachments on bug 8455: 6897 | 6912 | 6913 | 7005 | 7007