Attachment 6889 Details for Bug 8453 – git-am fix for 3.6.1.

[patch] git-am fix for 3.6.1.

0001-Fix-bug-8453-smbclient-segfaults-when-dialect-option.patch (text/plain), 1.08 KB, created by Jeremy Allison on 2011-09-14 18:56:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jeremy Allison

Created: 2011-09-14 18:56:59 UTC

Size: 1.08 KB

patch

obsolete

>From e94154edf73aeecd42a32086a9bfaaa267c7f528 Mon Sep 17 00:00:00 2001
>From: Jeremy Allison <jra@samba.org>
>Date: Wed, 14 Sep 2011 11:55:16 -0700
>Subject: [PATCH] Fix bug #8453 - smbclient segfaults when dialect option -m is used for legacy dialects
>
>Ensure we have valid pointers.
>---
> source3/libsmb/cliconnect.c |   13 +++++++++++++
> 1 files changed, 13 insertions(+), 0 deletions(-)
>
>diff --git a/source3/libsmb/cliconnect.c b/source3/libsmb/cliconnect.c
>index 81c1819..113b8a5 100644
>--- a/source3/libsmb/cliconnect.c
>+++ b/source3/libsmb/cliconnect.c
>@@ -1997,6 +1997,19 @@ NTSTATUS cli_session_setup(struct cli_state *cli,
> 	}
> 
> 	if (cli->protocol < PROTOCOL_LANMAN1) {
>+		/*
>+		 * Ensure cli->server_domain,
>+		 * cli->server_os and cli->server_type
>+		 * are valid pointers.
>+		 */
>+		cli->server_domain = talloc_strdup(cli, "");
>+		cli->server_os = talloc_strdup(cli, "");
>+		cli->server_type = talloc_strdup(cli, "");
>+		if (cli->server_domain == NULL ||
>+				cli->server_os == NULL ||
>+				cli->server_type == NULL) {
>+			return NT_STATUS_NO_MEMORY;
>+		}
> 		return NT_STATUS_OK;
> 	}
> 
>-- 
>1.7.3.1
>

Flags:

kukks: review+

Actions: View

Attachments on bug 8453: 6889