The Samba-Bugzilla – Attachment 6772 Details for
Bug 8370
vfs_chown_fsp broken -- returns in the wrong directory
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
8370.patch (text/plain), 948 bytes, created by
Volker Lendecke
on 2011-08-11 10:44:25 UTC
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Volker Lendecke
Created:
2011-08-11 10:44:25 UTC
Size:
948 bytes
patch
obsolete
>From 31dee9637c2f2096924f97465026accf860e54d3 Mon Sep 17 00:00:00 2001 >From: Volker Lendecke <vl@samba.org> >Date: Thu, 11 Aug 2011 12:37:53 +0200 >Subject: [PATCH] s3: Fix vfs_chown_fsp, fix bug 8370 > >The race fixes introduced a SMB_VFS_CHDIR into the parent directory of the >file. To get back to the original directory, we can't use vfs_ChDir which has a >cache which was not filled correctly with the direct VFS_CHDIR call. So we >never jumped back to the original directory. >--- > source3/smbd/vfs.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > >diff --git a/source3/smbd/vfs.c b/source3/smbd/vfs.c >index 3405a1c..340e7e5 100644 >--- a/source3/smbd/vfs.c >+++ b/source3/smbd/vfs.c >@@ -1543,7 +1543,7 @@ NTSTATUS vfs_chown_fsp(files_struct *fsp, uid_t uid, gid_t gid) > } > > if (as_root) { >- vfs_ChDir(fsp->conn,saved_dir); >+ SMB_VFS_CHDIR(fsp->conn,saved_dir); > TALLOC_FREE(saved_dir); > TALLOC_FREE(parent_dir); > } >-- >1.7.4.1 >
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=6772">View the attachment on a separate page</a>.</b>
View Attachment As Raw
Flags:
jra
:
review-
ambi
:
review+
Actions:
View
Attachments on
bug 8370
:
6772
|
6776
|
6777
|
6778
|
6779