Attachment 6750 Details for Bug 8345 – Patch

[patch] Patch

8345.patch (text/plain), 1.05 KB, created by Volker Lendecke on 2011-08-03 18:20:17 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Volker Lendecke

Created: 2011-08-03 18:20:17 UTC

Size: 1.05 KB

patch

obsolete

>From 63b501d9cba50bbcfdb2a32b323c19bd73b6ed79 Mon Sep 17 00:00:00 2001
>From: Volker Lendecke <vl@samba.org>
>Date: Wed, 3 Aug 2011 20:15:40 +0200
>Subject: [PATCH] s3: Fix bug 8345, memleak in hpuxacl module
>
>This correctly frees the hpuxacl structure in hpuxacl_sys_acl_delete_def_file
>---
> source3/modules/vfs_hpuxacl.c |    3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
>diff --git a/source3/modules/vfs_hpuxacl.c b/source3/modules/vfs_hpuxacl.c
>index 0f5af9d..51fd6d1 100644
>--- a/source3/modules/vfs_hpuxacl.c
>+++ b/source3/modules/vfs_hpuxacl.c
>@@ -373,7 +373,7 @@ int hpuxacl_sys_acl_delete_def_file(vfs_handle_struct *handle,
> {
> 	SMB_ACL_T smb_acl;
> 	int ret = -1;
>-	HPUX_ACL_T hpux_acl;
>+	HPUX_ACL_T hpux_acl = NULL;
> 	int count;
> 
> 	DEBUG(10, ("entering hpuxacl_sys_acl_delete_def_file.\n"));
>@@ -402,6 +402,7 @@ int hpuxacl_sys_acl_delete_def_file(vfs_handle_struct *handle,
>  done:
> 	DEBUG(10, ("hpuxacl_sys_acl_delete_def_file %s.\n",
> 		   ((ret != 0) ? "failed" : "succeeded" )));
>+	SAFE_FREE(hpux_acl);
> 	SAFE_FREE(smb_acl);
> 	return ret;
> }
>-- 
>1.7.4.1
>

Actions: View

Attachments on bug 8345: 6750 | 6753