Attachment 6745 Details for Bug 8341 – feed cli_trans a valid pointer for num_data when data is not null

feed cli_trans a valid pointer for num_data when data is not null

0001-s3-libsmb-clifsinfo-feed-cli_trans-with-a-valid-pointe.txt (text/plain), 1.28 KB, created by Alban Browaeys on 2011-08-01 22:23:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alban Browaeys

Created: 2011-08-01 22:23:24 UTC

Size: 1.28 KB

patch

obsolete

>From bb4907aceb2fe5439abb750db86bf6d1adec4a0b Mon Sep 17 00:00:00 2001
>From: Alban Browaeys <prahal@yahoo.com>
>Date: Tue, 2 Aug 2011 00:10:56 +0200
>Subject: [PATCH] s3:libsmb/clifsinfo: feed cli_trans with a valid pointer.
>
>Feed cli_trans with a valid num_data pointer. FIxes a segfault in
>cli_trans_recv (called by cli_trans) while :
>*num_data = ...
>when data is not null.
>Previously we were sending a NULL pointer which when dereferenced lead
>to a segfault. Segfault initially produced via gvfsd-smb when accessing
>the root of a mounted share.
>---
> source3/libsmb/clifsinfo.c |    3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
>diff --git a/source3/libsmb/clifsinfo.c b/source3/libsmb/clifsinfo.c
>index b0a8fdd..5f8e551 100644
>--- a/source3/libsmb/clifsinfo.c
>+++ b/source3/libsmb/clifsinfo.c
>@@ -483,6 +483,7 @@ NTSTATUS cli_get_posix_fs_info(struct cli_state *cli,
> 	uint16 setup[1];
> 	uint8_t param[2];
> 	uint8_t *rdata = NULL;
>+	uint32_t rdata_count;
> 	NTSTATUS status;
> 
> 	SSVAL(setup, 0, TRANSACT2_QFSINFO);
>@@ -495,7 +496,7 @@ NTSTATUS cli_get_posix_fs_info(struct cli_state *cli,
> 			   NULL,
> 			   NULL, 0, NULL, /* rsetup */
> 			   NULL, 0, NULL, /* rparam */
>-			   &rdata, 56, NULL);
>+			   &rdata, 56, &rdata_count);
> 	if (!NT_STATUS_IS_OK(status)) {
> 		return status;
> 	}
>-- 
>1.7.6
>

Actions: View

Attachments on bug 8341: 6745 | 6746