Attachment 6717 Details for Bug 8326 – Fixed patch for 3.6

[patch] Fixed patch for 3.6

0001-nbt-fix-WinXP-S3-domain-join-alignment-of-nbt_netlog.patch (text/plain), 978 bytes, created by Andrew Bartlett on 2011-07-27 02:56:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andrew Bartlett

Created: 2011-07-27 02:56:49 UTC

Size: 978 bytes

patch

obsolete

>From b34dc89196ad26a4c4a7a8e60f97044fd8c97c79 Mon Sep 17 00:00:00 2001
>From: Andrew Bartlett <abartlet@samba.org>
>Date: Wed, 27 Jul 2011 12:04:26 +1000
>Subject: [PATCH] nbt: fix WinXP S3 domain join: alignment of
> nbt_netlogon_response_from_pdc
>
>This fixes WinXP joining a Samba3 domain, which was broken on hosts
>with an even number of characters in the host name.  The alignment
>requested in the structure was ignored because of the overall
>NDR_NOALIGN set on the packet.
>
>Andrew Bartlett
>---
> librpc/idl/nbt.idl |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/librpc/idl/nbt.idl b/librpc/idl/nbt.idl
>index cbfa966..ee9a64e 100644
>--- a/librpc/idl/nbt.idl
>+++ b/librpc/idl/nbt.idl
>@@ -494,7 +494,7 @@ interface nbt
> 	} nbt_netlogon_query_for_pdc;
> 
> 	/* response from pdc */
>-	typedef [flag(NDR_NOALIGN),public] struct {
>+	typedef [public] struct {
> 		netlogon_command command;
> 		astring pdc_name;
> 		[flag(NDR_ALIGN2)]   DATA_BLOB _pad;
>-- 
>1.7.6
>

Flags:

jra: review+

Actions: View

Attachments on bug 8326: 6717