Attachment 6695 Details for Bug 8304 – git-am fix for 3.6.0

[patch] git-am fix for 3.6.0

0001-Fix-bug-Bug-8304-Uninitialized-variable-referenced-i.patch (text/plain), 1.20 KB, created by Jeremy Allison on 2011-07-12 20:09:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jeremy Allison

Created: 2011-07-12 20:09:11 UTC

Size: 1.20 KB

patch

obsolete

>From e19fbcbbd2d4b1cfc3de6665813a807234886ad6 Mon Sep 17 00:00:00 2001
>From: Jeremy Allison <jra@samba.org>
>Date: Tue, 12 Jul 2011 13:06:13 -0700
>Subject: [PATCH] Fix bug #Bug 8304 - Uninitialized variable referenced in error path.
>
>princ must not be used uninitialized. auth_data is not used at all.
>---
> source3/rpc_server/dcesrv_gssapi.c |    6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
>diff --git a/source3/rpc_server/dcesrv_gssapi.c b/source3/rpc_server/dcesrv_gssapi.c
>index 25d85a6..f027961 100644
>--- a/source3/rpc_server/dcesrv_gssapi.c
>+++ b/source3/rpc_server/dcesrv_gssapi.c
>@@ -105,7 +105,6 @@ NTSTATUS gssapi_server_get_user_info(struct gse_context *gse_ctx,
> 				     struct auth_serversupplied_info **server_info)
> {
> 	TALLOC_CTX *tmp_ctx;
>-	DATA_BLOB auth_data;
> 	DATA_BLOB pac;
> 	struct PAC_DATA *pac_data;
> 	struct PAC_LOGON_INFO *logon_info = NULL;
>@@ -135,6 +134,11 @@ NTSTATUS gssapi_server_get_user_info(struct gse_context *gse_ctx,
> 		goto done;
> 	}
> 
>+	status = gse_get_client_name(gse_ctx, tmp_ctx, &princ_name);
>+	if (!NT_STATUS_IS_OK(status)) {
>+		goto done;
>+	}
>+
> 	pac_data = talloc_zero(tmp_ctx, struct PAC_DATA);
> 	if (!pac_data) {
> 		status = NT_STATUS_NO_MEMORY;
>-- 
>1.7.1
>

Flags:

jra: review? (abartlet)
metze: review+

Actions: View

Attachments on bug 8304: 6695