Attachment 6665 Details for Bug 8286 – Patch for 3.6

[patch] Patch for 3.6

0001-s3-smb2-fix-smbd-crash-on-premature-end-of-smb2-conn.patch (text/plain), 1.27 KB, created by Christian Ambach on 2011-07-04 21:26:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Christian Ambach

Created: 2011-07-04 21:26:52 UTC

Size: 1.27 KB

patch

obsolete

>From ea03fdfea3319843a25643e42b7b8fa8dfa65f14 Mon Sep 17 00:00:00 2001
>From: Christian Ambach <ambi@samba.org>
>Date: Mon, 4 Jul 2011 17:55:54 +0200
>Subject: [PATCH] s3:smb2 fix smbd crash on premature end of smb2 conn (Bug
> 8286)
>
>when smbd tries to clean up locks after a premature end of a smb2
>connection, lock_db has already been freed and so it crashes
>
>this patch changes the order in which items are freed so that
>lock_db is still around when it is needed
>---
> source3/smbd/server_exit.c |    6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/source3/smbd/server_exit.c b/source3/smbd/server_exit.c
>index a853c77..4c71d8f 100644
>--- a/source3/smbd/server_exit.c
>+++ b/source3/smbd/server_exit.c
>@@ -152,9 +152,6 @@ static void exit_server_common(enum server_exit_reason how,
> 		rpc_lsarpc_shutdown();
> 	}
> 
>-	locking_end();
>-	printing_end();
>-
> 	/*
> 	 * we need to force the order of freeing the following,
> 	 * because smbd_msg_ctx is not a talloc child of smbd_server_conn.
>@@ -165,6 +162,9 @@ static void exit_server_common(enum server_exit_reason how,
> 	server_event_context_free();
> 	TALLOC_FREE(smbd_memcache_ctx);
> 
>+	locking_end();
>+	printing_end();
>+
> 	if (how != SERVER_EXIT_NORMAL) {
> 		DEBUGSEP(0);
> 		DEBUG(0,("Abnormal server exit: %s\n",
>-- 
>1.7.4.4
>

Flags:

metze: review+

Actions: View

Attachments on bug 8286: 6665