Attachment 6596 Details for Bug 8244 – proposed patch

[patch] proposed patch

0001-s3-modules-fix-Bug-8244-Cannot-copy-files-larger-tha.patch (text/plain), 1.56 KB, created by Christian Ambach on 2011-06-17 20:01:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Christian Ambach

Created: 2011-06-17 20:01:36 UTC

Size: 1.56 KB

patch

obsolete

>From 163955d32044538ff8d8679bdfc20f64377fc81a Mon Sep 17 00:00:00 2001
>From: Christian Ambach <ambi@samba.org>
>Date: Fri, 17 Jun 2011 21:54:30 +0200
>Subject: [PATCH] s3:modules fix Bug 8244 - Cannot copy files larger than 2 GB
> to Samba share
>
>the time_audit module uses int instead of uint64 as return value
>in get_alloc_size so that sizes of files larger than 2 GB are
>cut of leading to wrong replies to NtCreateAndX and Windows
>clients giving up
>
>While checking the types of all functions, I found two more wrong
>return value types that needed correction
>---
> source3/modules/vfs_time_audit.c |    6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/source3/modules/vfs_time_audit.c b/source3/modules/vfs_time_audit.c
>index 0f32619..25332e4 100644
>--- a/source3/modules/vfs_time_audit.c
>+++ b/source3/modules/vfs_time_audit.c
>@@ -564,7 +564,7 @@ static SMB_OFF_T smb_time_audit_lseek(vfs_handle_struct *handle,
> 				      files_struct *fsp,
> 				      SMB_OFF_T offset, int whence)
> {
>-	ssize_t result;
>+	SMB_OFF_T result;
> 	struct timespec ts1,ts2;
> 	double timediff;
> 
>@@ -721,7 +721,7 @@ static uint64_t smb_time_audit_get_alloc_size(vfs_handle_struct *handle,
> 					      files_struct *fsp,
> 					      const SMB_STRUCT_STAT *sbuf)
> {
>-	int result;
>+	uint64_t result;
> 	struct timespec ts1,ts2;
> 	double timediff;
> 
>@@ -2216,7 +2216,7 @@ static ssize_t smb_time_audit_aio_return(struct vfs_handle_struct *handle,
> 					 struct files_struct *fsp,
> 					 SMB_STRUCT_AIOCB *aiocb)
> {
>-	int result;
>+	ssize_t result;
> 	struct timespec ts1,ts2;
> 	double timediff;
> 
>-- 
>1.7.4.4
>

Flags:

vl: review+

Actions: View

Attachments on bug 8244: 6596