Attachment 6560 Details for Bug 8217 – patch for master and 3.6

[patch] patch for master and 3.6

net.conf.addshare.patch (text/plain), 1.29 KB, created by Michael Adam on 2011-06-10 11:55:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Michael Adam

Created: 2011-06-10 11:55:08 UTC

Size: 1.29 KB

patch

obsolete

>From 7c8e44aa211905d28d9208f9433a2eaf739b47b3 Mon Sep 17 00:00:00 2001
>From: Michael Adam <obnox@samba.org>
>Date: Fri, 10 Jun 2011 13:51:06 +0200
>Subject: [PATCH] s3:net conf addshare: do not stat-check the share path.
>
>Allow paths with % macros and paths that do not (yet...) exist.
>---
> source3/utils/net_conf.c |   17 -----------------
> 1 files changed, 0 insertions(+), 17 deletions(-)
>
>diff --git a/source3/utils/net_conf.c b/source3/utils/net_conf.c
>index 0ae1206..9381159 100644
>--- a/source3/utils/net_conf.c
>+++ b/source3/utils/net_conf.c
>@@ -585,7 +585,6 @@ static int net_conf_addshare(struct net_context *c,
> 	const char *comment = NULL;
> 	const char *guest_ok = "no";
> 	const char *writeable = "no";
>-	SMB_STRUCT_STAT sbuf;
> 	TALLOC_CTX *mem_ctx = talloc_stackframe();
> 
> 	if (c->display_usage) {
>@@ -685,22 +684,6 @@ static int net_conf_addshare(struct net_context *c,
> 		goto done;
> 	}
> 
>-	if (sys_stat(path, &sbuf, false) != 0) {
>-		d_fprintf(stderr,
>-			  _("ERROR: cannot stat path '%s' to ensure "
>-			    "this is a directory.\n"
>-			    "Error was '%s'.\n"),
>-			  path, strerror(errno));
>-		goto done;
>-	}
>-
>-	if (!S_ISDIR(sbuf.st_ex_mode)) {
>-		d_fprintf(stderr,
>-			  _("ERROR: path '%s' is not a directory.\n"),
>-			  path);
>-		goto done;
>-	}
>-
> 	/*
> 	 * start a transaction
> 	 */
>-- 
>1.7.1
>

Flags:

ambi: review+

Actions: View

Attachments on bug 8217: 6560