The Samba-Bugzilla – Attachment 6558 Details for
Bug 8216
winbind returns wrong results with sids2xids
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
0001-bug-in-source3-winbindd-winbindd_sids_to_xids.c.patch (text/plain), 1.64 KB, created by
Volker Lendecke
on 2011-06-10 10:33:52 UTC
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Volker Lendecke
Created:
2011-06-10 10:33:52 UTC
Size:
1.64 KB
patch
obsolete
>From 2b7ae365a220e75f3bf33aeaf7fc45f81e22b611 Mon Sep 17 00:00:00 2001 >From: Herb Lewis <hlewis@panasas.com> >Date: Thu, 9 Jun 2011 23:17:11 -0700 >Subject: [PATCH] bug in source3/winbindd/winbindd_sids_to_xids.c > >I'm having trouble getting my system setup to do submits right now but >I discovered a bug in the subject file that causes winbindd lookup sids >command to assign incorrect unix ids. The change to sid_peek_rid fixes >the case where you call lookup sids with sids s1 s2 s3 which cause them >to be cached. then call with s1 s2 s4 and s4 will get the unix id of s1. > >The other change fixes the case where a sid that was not translated >gets a value returned instead of being listed as unmapped. > >Could someone review this and push to master and 3.6 for me? >--- > source3/winbindd/winbindd_sids_to_xids.c | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletions(-) > >diff --git a/source3/winbindd/winbindd_sids_to_xids.c b/source3/winbindd/winbindd_sids_to_xids.c >index 68616fa..9c38b5a 100644 >--- a/source3/winbindd/winbindd_sids_to_xids.c >+++ b/source3/winbindd/winbindd_sids_to_xids.c >@@ -201,7 +201,7 @@ static void winbindd_sids_to_xids_lookupsids_done(struct tevent_req *subreq) > break; > }; > t->domain_index = n->sid_index; >- sid_peek_rid(&state->sids[i], &t->rid); >+ sid_peek_rid(&state->non_cached[i], &t->rid); > t->unix_id = (uint64_t)-1; > } > >@@ -268,6 +268,9 @@ NTSTATUS winbindd_sids_to_xids_recv(struct tevent_req *req, > } > } else { > unix_id = state->ids.ids[num_non_cached].unix_id; >+ if (unix_id == -1) { >+ found = false; >+ } > switch(state->ids.ids[num_non_cached].type) { > case WBC_ID_TYPE_UID: > type = 'U'; >-- >1.7.3.4 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Raw
Flags:
obnox
:
review+
Actions:
View
Attachments on
bug 8216
: 6558