The Samba-Bugzilla – Attachment 6502 Details for
Bug 8190
set the close on exec flag for the created pidfiles
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
patch for 3.5
samba-3.5.2-pidfile_fdleak.patch (text/plain), 778 bytes, created by
Guenther Deschner
on 2011-05-31 11:25:58 UTC
(
hide
)
Description:
patch for 3.5
Filename:
MIME Type:
Creator:
Guenther Deschner
Created:
2011-05-31 11:25:58 UTC
Size:
778 bytes
patch
obsolete
>From 20537d65166714f083256cf4f48b96d35786253a Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?G=C3=BCnther=20Deschner?= <gd@samba.org> >Date: Mon, 17 May 2010 18:22:37 +0200 >Subject: [PATCH] s3-pidfile: set the close on exec flag for the created pidfiles. > >Guenther >--- > source3/lib/pidfile.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > >diff --git a/source3/lib/pidfile.c b/source3/lib/pidfile.c >index 2c52d12..a3e39db 100644 >--- a/source3/lib/pidfile.c >+++ b/source3/lib/pidfile.c >@@ -145,6 +145,9 @@ void pidfile_create(const char *program_name) > } > /* Leave pid file open & locked for the duration... */ > SAFE_FREE(name); >+ >+ /* set the close on exec so that we don't leak the fd */ >+ fcntl(fd, F_SETFD, FD_CLOEXEC); > } > > void pidfile_unlink(void) >-- >1.6.6.1 >
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=6502">View the attachment on a separate page</a>.</b>
View Attachment As Raw
Actions:
View
Attachments on
bug 8190
: 6502