Attachment 6487 Details for Bug 8166 – Patch for 3.5

[patch] Patch for 3.5

0001-s3-winbind-BUG-8166-Don-t-lockout-users-when-offline.patch (text/plain), 1.27 KB, created by Jim McDonough on 2011-05-25 16:27:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jim McDonough

Created: 2011-05-25 16:27:54 UTC

Size: 1.27 KB

patch

obsolete

>From 49a4f79473567c33de63e1c720d6c88e13170989 Mon Sep 17 00:00:00 2001
>From: Jim McDonough <jmcd@samba.org>
>Date: Wed, 25 May 2011 10:49:41 -0400
>Subject: [PATCH] s3-winbind: BUG 8166 - Don't lockout users when offline.
>
>Windows does not track bad password attempts when offline.  We were locking users out but not honoring the lockout duration.
>
>Autobuild-User: Jim McDonough <jmcd@samba.org>
>Autobuild-Date: Wed May 25 18:11:10 CEST 2011 on sn-devel-104
>(cherry picked from commit b58534f1fca27e3e72f4f4107538ec05734bd42a)
>---
> source3/winbindd/winbindd_pam.c |    5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
>diff --git a/source3/winbindd/winbindd_pam.c b/source3/winbindd/winbindd_pam.c
>index aab3b72..df83dc6 100644
>--- a/source3/winbindd/winbindd_pam.c
>+++ b/source3/winbindd/winbindd_pam.c
>@@ -1071,7 +1071,10 @@ static NTSTATUS winbindd_dual_pam_auth_cached(struct winbindd_domain *domain,
> 
> 	}
> 
>-	/* User does *NOT* know the correct password, modify info3 accordingly */
>+	/* User does *NOT* know the correct password, modify info3 accordingly, but only if online */
>+	if (domain->online == false) {
>+		goto failed;
>+	}
> 
> 	/* failure of this is not critical */
> 	result = get_max_bad_attempts_from_lockout_policy(domain, state->mem_ctx, &max_allowed_bad_attempts);
>-- 
>1.7.4.2
>

Flags:

obnox: review+

Actions: View

Attachments on bug 8166: 6486 | 6487