Attachment 6471 Details for Bug 8151 – Depricate the optional port syntax of password server

[patch] Depricate the optional port syntax of password server

0004-s3-param-Depricate-password-server-foo-12389-syntax.patch (text/plain), 1.12 KB, created by Andrew Bartlett on 2011-05-23 02:18:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andrew Bartlett

Created: 2011-05-23 02:18:27 UTC

Size: 1.12 KB

patch

obsolete

>From 76e4d3bcde51346b036862502bec5a8f5b7bfa76 Mon Sep 17 00:00:00 2001
>From: Andrew Bartlett <abartlet@samba.org>
>Date: Mon, 23 May 2011 10:42:57 +1000
>Subject: [PATCH 4/4] s3-param Depricate 'password server = foo:12389' syntax
>
>This was originally intended to allow the LDAP port on a DC to be
>varied, but makes little sense to change one port when in an
>environment where krb5, ldap, smb and potentially DCE/RPC over TCP are
>involved.
>
>Andrew Bartlett
>---
> source3/param/loadparm.c |    5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
>diff --git a/source3/param/loadparm.c b/source3/param/loadparm.c
>index fc19656..d296921 100644
>--- a/source3/param/loadparm.c
>+++ b/source3/param/loadparm.c
>@@ -9586,6 +9586,11 @@ static bool lp_load_ex(const char *pszFname,
> 		DEBUG(1, ("WARNING: The security=server option is deprecated\n"));
> 	}
> 
>+	if (lp_security() == SEC_ADS && strchr(lp_passwordserver(), ':')) {
>+		DEBUG(1, ("WARNING: The optional ':port' in password server = %s is depricated\n",
>+			  lp_passwordserver()));
>+	}
>+
> 	bLoaded = True;
> 
> 	/* Now we check bWINSsupport and set szWINSserver to 127.0.0.1 */
>-- 
>1.7.4.4
>

Actions: View

Attachments on bug 8151: 6468 | 6469 | 6470 | 6471 | 6473 | 6480