Attachment 6408 Details for Bug 8087 – Patch for 3.5

[patch] Patch for 3.5

0001-libwbclient-Fix-bug-8087-wbcChangeUserPasswordEx-in-.patch (text/plain), 2.68 KB, created by Volker Lendecke on 2011-04-15 06:42:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Volker Lendecke

Created: 2011-04-15 06:42:09 UTC

Size: 2.68 KB

patch

obsolete

>From 64c11561308e37ff7802758c734dc0cdb3dc2c37 Mon Sep 17 00:00:00 2001
>From: Volker Lendecke <vl@samba.org>
>Date: Fri, 23 Apr 2010 19:41:29 +0200
>Subject: [PATCH] libwbclient: Fix bug 8087 -- wbcChangeUserPasswordEx in RESPONSE mode does not work
>
>This is 03115efae89c8c4f51dea1ce82613817bd9fcf5b from master
>
>Actually copy something in wbcChangeUserPasswordEx
>
>The length argument for memcpy was initialized to 0 and not initialized
>---
> nsswitch/libwbclient/wbc_pam.c |   16 ++++++++--------
> 1 files changed, 8 insertions(+), 8 deletions(-)
>
>diff --git a/nsswitch/libwbclient/wbc_pam.c b/nsswitch/libwbclient/wbc_pam.c
>index 25475ce..8c725d2 100644
>--- a/nsswitch/libwbclient/wbc_pam.c
>+++ b/nsswitch/libwbclient/wbc_pam.c
>@@ -865,35 +865,35 @@ wbcErr wbcChangeUserPasswordEx(const struct wbcChangePasswordParams *params,
> 			sizeof(request.data.chng_pswd_auth_crap.domain) - 1);
> 
> 		if (params->new_password.response.nt_data) {
>+			request.data.chng_pswd_auth_crap.new_nt_pswd_len =
>+				params->new_password.response.nt_length;
> 			memcpy(request.data.chng_pswd_auth_crap.new_nt_pswd,
> 			       params->new_password.response.nt_data,
> 			       request.data.chng_pswd_auth_crap.new_nt_pswd_len);
>-			request.data.chng_pswd_auth_crap.new_nt_pswd_len =
>-				params->new_password.response.nt_length;
> 		}
> 
> 		if (params->new_password.response.lm_data) {
>+			request.data.chng_pswd_auth_crap.new_lm_pswd_len =
>+				params->new_password.response.lm_length;
> 			memcpy(request.data.chng_pswd_auth_crap.new_lm_pswd,
> 			       params->new_password.response.lm_data,
> 			       request.data.chng_pswd_auth_crap.new_lm_pswd_len);
>-			request.data.chng_pswd_auth_crap.new_lm_pswd_len =
>-				params->new_password.response.lm_length;
> 		}
> 
> 		if (params->old_password.response.old_nt_hash_enc_data) {
>+			request.data.chng_pswd_auth_crap.old_nt_hash_enc_len =
>+				params->old_password.response.old_nt_hash_enc_length;
> 			memcpy(request.data.chng_pswd_auth_crap.old_nt_hash_enc,
> 			       params->old_password.response.old_nt_hash_enc_data,
> 			       request.data.chng_pswd_auth_crap.old_nt_hash_enc_len);
>-			request.data.chng_pswd_auth_crap.old_nt_hash_enc_len =
>-				params->old_password.response.old_nt_hash_enc_length;
> 		}
> 
> 		if (params->old_password.response.old_lm_hash_enc_data) {
>+			request.data.chng_pswd_auth_crap.old_lm_hash_enc_len =
>+				params->old_password.response.old_lm_hash_enc_length;
> 			memcpy(request.data.chng_pswd_auth_crap.old_lm_hash_enc,
> 			       params->old_password.response.old_lm_hash_enc_data,
> 			       request.data.chng_pswd_auth_crap.old_lm_hash_enc_len);
>-			request.data.chng_pswd_auth_crap.old_lm_hash_enc_len =
>-				params->old_password.response.old_lm_hash_enc_length;
> 		}
> 
> 		break;
>-- 
>1.7.0.4
>

Flags:

gd: review+

Actions: View

Attachments on bug 8087: 6408