Attachment 6370 Details for Bug 8042 – Patch for 3.5

[patch] Patch for 3.5

0001-s3-Fix-bug-8042-File-creation-on-OS-X.patch (text/plain), 1.07 KB, created by Volker Lendecke on 2011-04-03 12:11:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Volker Lendecke

Created: 2011-04-03 12:11:45 UTC

Size: 1.07 KB

patch

obsolete

>From e868d083304025f00a953399c0478ee2e031f5bf Mon Sep 17 00:00:00 2001
>From: Volker Lendecke <vl@samba.org>
>Date: Sun, 3 Apr 2011 13:57:11 +0200
>Subject: [PATCH] s3: Fix bug 8042: File creation on OS/X
>
>With a case insensitive file system the stat cache lookup leaked the parent
>directorys stat information from unix_convert into the smb_filename. This led
>open_file_ntcreate to believe it just created a directory.
>
>In the case where we do the search we already invalidate the stat struct.
>
>Thanks to TAKAHASHI Motonobu for insisting! :-)
>
>Volker
>---
> source3/smbd/filename.c |    4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
>diff --git a/source3/smbd/filename.c b/source3/smbd/filename.c
>index 154d34a..4f7e070 100644
>--- a/source3/smbd/filename.c
>+++ b/source3/smbd/filename.c
>@@ -401,6 +401,10 @@ NTSTATUS unix_convert(TALLOC_CTX *ctx,
> 						goto fail;
> 					}
> 				}
>+
>+				/* Stat failed - ensure we don't use it. */
>+				SET_STAT_INVALID(smb_fname->st);
>+
> 				/*
> 				 * Missing last component is ok - new file.
> 				 * Also deal with permission denied elsewhere.
>-- 
>1.7.0.4
>

Flags:

jra: review-

Actions: View

Attachments on bug 8042: 6351 | 6352 | 6369 | 6370 | 6373 | 6374