Attachment 6366 Details for Bug 8054 – Fix #2 for 3.5.next.

[patch] Fix #2 for 3.5.next.

0002-s3-Fix-Coverity-ID-1137-CONSTANT_EXPRESSION_RESULT.patch (text/plain), 1.18 KB, created by Jeremy Allison on 2011-04-01 22:54:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jeremy Allison

Created: 2011-04-01 22:54:06 UTC

Size: 1.18 KB

patch

obsolete

>From 1272758f8f989647802ea90722661ab133efa83f Mon Sep 17 00:00:00 2001
>From: Volker Lendecke <vl@samba.org>
>Date: Fri, 1 Apr 2011 08:40:38 +0200
>Subject: [PATCH 2/2] s3: Fix Coverity ID 1137: CONSTANT_EXPRESSION_RESULT
>
>Autobuild-User: Volker Lendecke <vlendec@samba.org>
>Autobuild-Date: Fri Apr  1 09:35:19 CEST 2011 on sn-devel-104
>---
> source3/winbindd/winbindd_cache.c |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/source3/winbindd/winbindd_cache.c b/source3/winbindd/winbindd_cache.c
>index 57a93a7..68a8625 100644
>--- a/source3/winbindd/winbindd_cache.c
>+++ b/source3/winbindd/winbindd_cache.c
>@@ -246,7 +246,7 @@ static uint16 centry_uint16(struct cache_entry *centry)
> 	if (!centry_check_bytes(centry, 2)) {
> 		smb_panic_fn("centry_uint16");
> 	}
>-	ret = CVAL(centry->data, centry->ofs);
>+	ret = SVAL(centry->data, centry->ofs);
> 	centry->ofs += 2;
> 	return ret;
> }
>@@ -792,7 +792,7 @@ static void centry_put_uint32(struct cache_entry *centry, uint32 v)
> static void centry_put_uint16(struct cache_entry *centry, uint16 v)
> {
> 	centry_expand(centry, 2);
>-	SIVAL(centry->data, centry->ofs, v);
>+	SSVAL(centry->data, centry->ofs, v);
> 	centry->ofs += 2;
> }
> 
>-- 
>1.7.3.1
>

Flags:

vl: review+

Actions: View

Attachments on bug 8054: 6365 | 6366