Attachment 6155 Details for Bug 7815 – Additional patch to fix the get/set sparse issue.

[patch] Additional patch to fix the get/set sparse issue.

look32 (text/plain), 1012 bytes, created by Jeremy Allison on 2010-12-20 12:28:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jeremy Allison

Created: 2010-12-20 12:28:23 UTC

Size: 1012 bytes

patch

obsolete

>diff --git a/source3/include/smb.h b/source3/include/smb.h
>index b87caf2..2b397cc 100644
>--- a/source3/include/smb.h
>+++ b/source3/include/smb.h
>@@ -1211,8 +1211,7 @@ struct bitmap {
> 					FILE_ATTRIBUTE_HIDDEN|\
> 					FILE_ATTRIBUTE_SYSTEM|\
> 					FILE_ATTRIBUTE_DIRECTORY|\
>-					FILE_ATTRIBUTE_ARCHIVE|\
>-					FILE_ATTRIBUTE_SPARSE)
>+					FILE_ATTRIBUTE_ARCHIVE)
> 
> /* Flags - combined with attributes. */
> #define FILE_FLAG_WRITE_THROUGH    0x80000000L
>diff --git a/source3/smbd/dosmode.c b/source3/smbd/dosmode.c
>index 628f887..2c6dcd0 100644
>--- a/source3/smbd/dosmode.c
>+++ b/source3/smbd/dosmode.c
>@@ -318,7 +318,8 @@ static bool get_ea_dos_attribute(connection_struct *conn,
> 	if (S_ISDIR(smb_fname->st.st_ex_mode)) {
> 		dosattr |= aDIR;
> 	}
>-	*pattr = (uint32)(dosattr & SAMBA_ATTRIBUTES_MASK);
>+	/* FILE_ATTRIBUTE_SPARSE is valid on get but not on set. */
>+	*pattr = (uint32)(dosattr & (SAMBA_ATTRIBUTES_MASK|FILE_ATTRIBUTE_SPARSE));
> 
> 	DEBUG(8,("get_ea_dos_attribute returning (0x%x)", dosattr));
>

Actions: View

Attachments on bug 7815: 6139 | 6140 | 6141 | 6142 | 6143 | 6144 | 6145 | 6146 | 6147 | 6148 | 6149 | 6150 | 6155