Attachment 5968 Details for Bug 7688 – Patch for 3.5

[patch] Patch for 3.5

0001-s3-Fix-bug-7688-rpcclient-command-line-completion-cr.patch (text/plain), 1.04 KB, created by Volker Lendecke on 2010-09-18 09:52:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Volker Lendecke

Created: 2010-09-18 09:52:18 UTC

Size: 1.04 KB

patch

obsolete

>From 259ba0316e0f0c2045c98b5dc5fa68712fb4bec2 Mon Sep 17 00:00:00 2001
>From: Volker Lendecke <vl@samba.org>
>Date: Sat, 18 Sep 2010 07:37:04 -0700
>Subject: [PATCH] s3: Fix bug 7688, rpcclient command line completion crashing
>
>We've grown more than 100 rpcclient commands by now, so this would overwrite
>the array of 100 completions. There's nicer ways to fix this problem, but 1000
>rpcclient commands should be at least a bit away.
>---
> source3/rpcclient/rpcclient.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/source3/rpcclient/rpcclient.c b/source3/rpcclient/rpcclient.c
>index e24538b..f05facb 100644
>--- a/source3/rpcclient/rpcclient.c
>+++ b/source3/rpcclient/rpcclient.c
>@@ -49,7 +49,7 @@ handle completion of commands for readline
> ****************************************************************************/
> static char **completion_fn(const char *text, int start, int end)
> {
>-#define MAX_COMPLETIONS 100
>+#define MAX_COMPLETIONS 1000
> 	char **matches;
> 	int i, count=0;
> 	struct cmd_list *commands = cmd_list;
>-- 
>1.7.0.4
>

Flags:

jra: review+

Actions: View

Attachments on bug 7688: 5968