Attachment 5900 Details for Bug 7617 – git-am format patch for 3.5.x.

[patch] git-am format patch for 3.5.x.

0001-Fix-bug-7617-smbd-coredump-due-to-uninitialized-vari.patch (text/plain), 1.20 KB, created by Jeremy Allison on 2010-08-12 17:42:56 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jeremy Allison

Created: 2010-08-12 17:42:56 UTC

Size: 1.20 KB

patch

obsolete

>From 9ee199768383a1dc4d4efcedecd5f65c569b6895 Mon Sep 17 00:00:00 2001
>From: Jeremy Allison <jra@samba.org>
>Date: Thu, 12 Aug 2010 14:24:01 -0700
>Subject: [PATCH] Fix bug #7617 - smbd coredump due to uninitialized variables in the performance counter code.
>
>In the file rpc_server.c, function _winreg_QueryValue()
>
>uint8_t *outbuf
>
>Should be :
>
>uint8_t *outbuf = NULL;
>
>As it is later freed by
>
>      if (free_buf) SAFE_FREE(outbuf);
>
>in some cases, this frees the unintialized outbuf, which causes a coredump.
>(cherry picked from commit 84fd910c347ddfad6f01edbe7f6e25546c8382ee)
>---
> source3/rpc_server/srv_winreg_nt.c |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/source3/rpc_server/srv_winreg_nt.c b/source3/rpc_server/srv_winreg_nt.c
>index 04c9c8c..e840a8f 100644
>--- a/source3/rpc_server/srv_winreg_nt.c
>+++ b/source3/rpc_server/srv_winreg_nt.c
>@@ -220,8 +220,8 @@ WERROR _winreg_QueryValue(pipes_struct *p, struct winreg_QueryValue *r)
> 	struct registry_key *regkey = find_regkey_by_hnd( p, r->in.handle );
> 	prs_struct    prs_hkpd;
> 
>-	uint8_t *outbuf;
>-	uint32_t outbuf_size;
>+	uint8_t *outbuf = NULL;
>+	uint32_t outbuf_size = 0;
> 
> 	DATA_BLOB val_blob;
> 	bool free_buf = False;
>-- 
>1.7.1
>

Flags:

gd: review+

Actions: View

Attachments on bug 7617: 5900