Attachment 576 Details for Bug 1548 – patch for segfault and version (python spoolss getprinterdriver)

[patch] patch for segfault and version (python spoolss getprinterdriver)

samba3-3.0.5rc1-python-getdriver.patch (text/plain), 1.00 KB, created by Daniel Jarboe on 2004-07-22 05:29:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Daniel Jarboe

Created: 2004-07-22 05:29:11 UTC

Size: 1.00 KB

patch

obsolete

>--- py_spoolss_drivers.c.orig	2004-07-22 07:52:05.000000000 -0400
>+++ py_spoolss_drivers.c	2004-07-22 08:21:38.000000000 -0400
>@@ -178,24 +178,26 @@
> 	uint32 needed;
> 	char *arch = "Windows NT x86";
> 	int version = 2;
>-	static char *kwlist[] = {"level", "arch", NULL};
>+	static char *kwlist[] = {"level", "arch", "version", NULL};
> 
> 	/* Parse parameters */
> 
> 	if (!PyArg_ParseTupleAndKeywords(
>-		    args, kw, "|is", kwlist, &level, &arch))
>+		    args, kw, "|isi", kwlist, &level, &arch, &version))
> 		return NULL;
> 
>+	ZERO_STRUCT(ctr);
>+
> 	/* Call rpc function */
> 
> 	werror = cli_spoolss_getprinterdriver(
> 		hnd->cli, hnd->mem_ctx, 0, &needed, &hnd->pol, level,
>-		version, arch, &ctr);
>+		arch, version, &ctr);
> 
> 	if (W_ERROR_V(werror) == ERRinsufficientbuffer)
> 		werror = cli_spoolss_getprinterdriver(
> 			hnd->cli, hnd->mem_ctx, needed, NULL, &hnd->pol,
>-			level, version, arch, &ctr);
>+			level, arch, version, &ctr);
> 
> 	if (!W_ERROR_IS_OK(werror)) {
> 		PyErr_SetObject(spoolss_werror, py_werror_tuple(werror));

Actions: View

Attachments on bug 1548: 576