The Samba-Bugzilla – Attachment 5756 Details for
Bug 7487
SMB2: rename fails.
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
proposed patch so rename works.
rename_fix.patch (text/plain), 950 bytes, created by
Ira Cooper
on 2010-06-01 17:50:10 UTC
(
hide
)
Description:
proposed patch so rename works.
Filename:
MIME Type:
Creator:
Ira Cooper
Created:
2010-06-01 17:50:10 UTC
Size:
950 bytes
patch
obsolete
>commit b5c3fc5b8d8a0d7592c3f6e1ffa2b69111aae756 >Author: Ira Cooper <samba@ira.wakeful.net> >Date: Tue Jun 1 18:37:01 2010 -0400 > > SMB2: Fix rename on Windows 7. > > This removes some code Jeremy (jra) suspected was bad. It turns out that the > command window rename command will not work with the offending code in place. > > With it removed the bug is gone, and rename works. > >diff --git a/source3/smbd/trans2.c b/source3/smbd/trans2.c >index 2c0bca9..f69cefe 100644 >--- a/source3/smbd/trans2.c >+++ b/source3/smbd/trans2.c >@@ -6003,14 +6003,6 @@ static NTSTATUS smb2_file_rename_information(connection_struct *conn, > return status; > } > >- /* Ok, this looks wrong to me, but appears to >- * be how SMB2 renames work. CHECK WITH Microsoft ! >- * jra. >- */ >- if (fsp->oplock_type != NO_OPLOCK) { >- return NT_STATUS_SHARING_VIOLATION; >- } >- > if (fsp->base_fsp) { > /* newname must be a stream name. */ > if (newname[0] != ':') {
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=5756">View the attachment on a separate page</a>.</b>
View Attachment As Raw
Flags:
ira
:
review?
(
jra
)
Actions:
View
Attachments on
bug 7487
: 5756