Attachment 5688 Details for Bug 7417 – patch for 3.4

[patch] patch for 3.4

patch-v3-4-test (text/plain), 1.05 KB, created by Guenther Deschner on 2010-05-10 03:42:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Guenther Deschner

Created: 2010-05-10 03:42:41 UTC

Size: 1.05 KB

patch

obsolete

>From 33b5ffb6ff8ebefc35f6da0c7c14f36fa026309a Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?G=C3=BCnther=20Deschner?= <gd@samba.org>
>Date: Sat, 8 May 2010 02:16:37 +0200
>Subject: [PATCH] s3-net: Fix Bug #7417. 'net rpc user password' can set the wrong password.
>
>Guenther
>(cherry picked from commit 7887d99a60387e93ce5ce4a3bfe9117939d1e4c8)
>---
> source3/utils/net_rpc.c |    5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
>diff --git a/source3/utils/net_rpc.c b/source3/utils/net_rpc.c
>index 75726b0..aa04172 100644
>--- a/source3/utils/net_rpc.c
>+++ b/source3/utils/net_rpc.c
>@@ -758,8 +758,11 @@ static int rpc_user_password(struct net_context *c, int argc, const char **argv)
> 		if (asprintf(&prompt, "Enter new password for %s:", argv[0]) == -1) {
> 			return -1;
> 		}
>-		u1003.usri1003_password = getpass(prompt);
>+		u1003.usri1003_password = talloc_strdup(c, getpass(prompt));
> 		SAFE_FREE(prompt);
>+		if (u1003.usri1003_password == NULL) {
>+			return -1;
>+		}
> 	}
> 
> 	status = NetUserSetInfo(c->opt_host, argv[0], 1003, (uint8_t *)&u1003, &parm_err);
>-- 
>1.6.6.1
>

Flags:

vl: review+

Actions: View

Attachments on bug 7417: 5687 | 5688 | 5689