Attachment 5683 Details for Bug 7407 – patch -- disable use of server inode numbers by default

[patch] patch -- disable use of server inode numbers by default

0001-cifs-disable-the-use-of-server-inode-numbers-by-defa.patch (text/plain), 1.77 KB, created by Jeff Layton on 2010-05-04 11:40:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jeff Layton

Created: 2010-05-04 11:40:40 UTC

Size: 1.77 KB

patch

obsolete

>From 4f36bb887f7483d7b2f008046c6aaf6bb004d9ce Mon Sep 17 00:00:00 2001
>From: Jeff Layton <jlayton@redhat.com>
>Date: Tue, 4 May 2010 18:37:12 +0200
>Subject: [PATCH] cifs: disable the use of server inode numbers by default
>
>We have a bit of a problem with server inode numbers...
>
>The FILE_UNIX_BASIC_INFO struct has a UniqueID field that is supposed to
>be unique across the scope of the share. It turns out that all current
>and past versions of Samba simply stuffed the inode number in this
>field. If you have a share that spans multiple filesystems on the
>server, then it's *likely* that the server will send the same value for
>more than one inode, leading to collisions.
>
>Given that, it's really pretty dangerous to trust this info from the
>server at this time. This patch simply makes the default "noserverino".
>To reenable it, admins will have to mount with "serverino". We'll
>continue to pursue fixes for this problem in the meantime, so hopefully
>this is just a temporary measure.
>
>Signed-off-by: Jeff Layton <jlayton@redhat.com>
>---
> fs/cifs/connect.c |    9 +++++++--
> 1 files changed, 7 insertions(+), 2 deletions(-)
>
>diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
>index 9123c23..a60c977 100644
>--- a/fs/cifs/connect.c
>+++ b/fs/cifs/connect.c
>@@ -839,8 +839,13 @@ cifs_parse_mount_options(char *options, const char *devname,
> 	/* vol->retry default is 0 (i.e. "soft" limited retry not hard retry) */
> 	/* default is always to request posix paths. */
> 	vol->posix_paths = 1;
>-	/* default to using server inode numbers where available */
>-	vol->server_ino = 1;
>+
>+	/*
>+	 * The client cannot default to using server inode numbers until it
>+	 * can reliably guard against misbehaving servers causing inode
>+	 * number collisions.
>+	 */
>+	vol->server_ino = 0;
> 
> 	if (!options)
> 		return 1;
>-- 
>1.7.0.1
>

Actions: View

Attachments on bug 7407: 5683