Attachment 5545 Details for Bug 7297 – git am format patch for 3.5.2 and 3.4.8.

[patch] git am format patch for 3.5.2 and 3.4.8.

0001-Fix-bug-7297-smbd-crashes-with-CUPS-printers-and-no-.patch (text/plain), 977 bytes, created by Jeremy Allison on 2010-03-25 19:20:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jeremy Allison

Created: 2010-03-25 19:20:02 UTC

Size: 977 bytes

patch

obsolete

>From 2e00a8a74b7c5c95b61e6c7f365ed852c7d95289 Mon Sep 17 00:00:00 2001
>From: Jeremy Allison <jra@samba.org>
>Date: Thu, 25 Mar 2010 17:09:23 -0700
>Subject: [PATCH] Fix bug 7297 - smbd crashes with CUPS printers and no [printers] share defined.
>
>Ensure we don't dereference an array with an index of -1.
>
>Jeremy.
>---
> source3/smbd/service.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/source3/smbd/service.c b/source3/smbd/service.c
>index db54d46..36184af 100644
>--- a/source3/smbd/service.c
>+++ b/source3/smbd/service.c
>@@ -339,7 +339,7 @@ int find_service(fstring service)
> 		if ((iPrinterService = lp_servicenumber(PRINTERS_NAME)) < 0) {
> 			iPrinterService = load_registry_service(PRINTERS_NAME);
> 		}
>-		if (iPrinterService) {
>+		if (iPrinterService >= 0) {
> 			DEBUG(3,("checking whether %s is a valid printer name...\n", service));
> 			if (pcap_printername_ok(service)) {
> 				DEBUG(3,("%s is a valid printer name\n", service));
>-- 
>1.6.3.3
>

Flags:

gd: review+

Actions: View

Attachments on bug 7297: 5545