Attachment 5420 Details for Bug 7176 – patch for 3.4

[patch] patch for 3.4

v3-4-test-devmode-strings.patch (text/plain), 1.06 KB, created by Guenther Deschner on 2010-02-25 03:33:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Guenther Deschner

Created: 2010-02-25 03:33:52 UTC

Size: 1.06 KB

patch

obsolete

>From 753b9c6d566fafee9724a84fbd91316767c1c7a2 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?G=C3=BCnther=20Deschner?= <gd@samba.org>
>Date: Mon, 30 Nov 2009 18:10:59 +0100
>Subject: [PATCH] s3-spoolss: fix fstrings in convert_devicemode() function.
>
>Guenther
>---
> source3/rpc_server/srv_spoolss_nt.c |    7 +++++--
> 1 files changed, 5 insertions(+), 2 deletions(-)
>
>diff --git a/source3/rpc_server/srv_spoolss_nt.c b/source3/rpc_server/srv_spoolss_nt.c
>index 8d7973d..d742048 100644
>--- a/source3/rpc_server/srv_spoolss_nt.c
>+++ b/source3/rpc_server/srv_spoolss_nt.c
>@@ -1484,8 +1484,11 @@ bool convert_devicemode(const char *printername,
> 			return false;
> 	}
> 
>-	rpcstr_push(nt_devmode->devicename, devmode->devicename, 31, 0);
>-	rpcstr_push(nt_devmode->formname, devmode->formname, 31, 0);
>+	fstrcpy(nt_devmode->devicename, devmode->devicename);
>+	fstrcpy(nt_devmode->formname, devmode->formname);
>+
>+	nt_devmode->devicename[31] = '\0';
>+	nt_devmode->formname[31] = '\0';
> 
> 	nt_devmode->specversion		= devmode->specversion;
> 	nt_devmode->driverversion	= devmode->driverversion;
>-- 
>1.6.6
>

Flags:

metze: review+

Actions: View

Attachments on bug 7176: 5420