Attachment 5387 Details for Bug 7155 – git-am fix for 3.4.6.

[patch] git-am fix for 3.4.6.

0001-Fix-bug-7155-valgrind-Conditional-jump-or-move-depen.patch (text/plain), 1.04 KB, created by Jeremy Allison on 2010-02-18 14:28:04 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jeremy Allison

Created: 2010-02-18 14:28:04 UTC

Size: 1.04 KB

patch

obsolete

>From 0cd8f41fc07b108788deda595e930a29e5f9fd11 Mon Sep 17 00:00:00 2001
>From: Jeremy Allison <jra@samba.org>
>Date: Thu, 18 Feb 2010 12:21:10 -0800
>Subject: [PATCH] Fix bug #7155 - valgrind Conditional jump or move depends on uninitialised value(s) error when "mangling method = hash"
>
>The charset array allocated in init_chartest() is allocated
>by MALLOC, but only some elements of it being set after allocation. Fix is to
>memset to zero after allocation.
>
>Jeremy.
>(cherry picked from commit a4e8210ba7d6d471cb9f17754244393b9c1e5930)
>---
> source3/smbd/mangle_hash.c |    1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
>diff --git a/source3/smbd/mangle_hash.c b/source3/smbd/mangle_hash.c
>index 8369af4..b54dd5c 100644
>--- a/source3/smbd/mangle_hash.c
>+++ b/source3/smbd/mangle_hash.c
>@@ -331,6 +331,7 @@ static void init_chartest( void )
> 	chartest = SMB_MALLOC_ARRAY(unsigned char, 256);
> 
> 	SMB_ASSERT(chartest != NULL);
>+	memset(chartest, '\0', 256);
> 
> 	for( s = (const unsigned char *)basechars; *s; s++ ) {
> 		chartest[*s] |= BASECHAR_MASK;
>-- 
>1.6.6.2
>

Flags:

vl: review+

Actions: View

Attachments on bug 7155: 5386 | 5387 | 5388