The Samba-Bugzilla – Attachment 5289 Details for
Bug 7106
mal-formed require-membership_of_sid.
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
patch for v3-3-test
malformed-require-membership-v3-3-test-mbox.diff (text/plain), 1.39 KB, created by
Bo Yang
on 2010-02-06 01:30:37 UTC
(
hide
)
Description:
patch for v3-3-test
Filename:
MIME Type:
Creator:
Bo Yang
Created:
2010-02-06 01:30:37 UTC
Size:
1.39 KB
patch
obsolete
>From e57af84af33278e2a46e898ba9f7a7c79d32ea54 Mon Sep 17 00:00:00 2001 >From: Bo Yang <boyang@samba.org> >Date: Sun, 7 Feb 2010 15:04:51 +0800 >Subject: [PATCH] s3: Fix malformed require_membership_of_sid. > >Signed-off-by: Bo Yang <boyang@samba.org> >--- > source/nsswitch/pam_winbind.c | 12 ++++++++++++ > 1 files changed, 12 insertions(+), 0 deletions(-) > >diff --git a/source/nsswitch/pam_winbind.c b/source/nsswitch/pam_winbind.c >index 7454081..5dccba1 100644 >--- a/source/nsswitch/pam_winbind.c >+++ b/source/nsswitch/pam_winbind.c >@@ -1036,6 +1036,7 @@ static bool winbind_name_list_to_sid_string_list(struct pwb_context *ctx, > char *current_name = NULL; > const char *search_location; > const char *comma; >+ int len; > > if (sid_list_buffer_size > 0) { > sid_list_buffer[0] = 0; >@@ -1091,6 +1092,17 @@ static bool winbind_name_list_to_sid_string_list(struct pwb_context *ctx, > _make_remark_format(ctx, PAM_TEXT_INFO, _("Cannot convert group %s " > "to sid, please contact your administrator to see " > "if group %s is valid."), search_location, search_location); >+ /* >+ * The lookup of the last name failed.. >+ * It results in require_member_of_sid ends with ',' >+ * It is malformated parameter here, overwrite the last ','. >+ */ >+ len = strlen(sid_list_buffer); >+ if (len) { >+ if (sid_list_buffer[len - 1] == ',') { >+ sid_list_buffer[len - 1] = '\0'; >+ } >+ } > } > > result = true; >-- >1.5.3 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Raw
Flags:
jmcd
:
review+
Actions:
View
Attachments on
bug 7106
: 5289 |
5290
|
5291