Attachment 5198 Details for Bug 7046 – Patch for 3.3

Patch for 3.3

7406-3.3.0.patch (text/x-diff), 1020 bytes, created by Volker Lendecke on 2010-01-16 06:59:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Volker Lendecke

Created: 2010-01-16 06:59:45 UTC

Size: 1020 bytes

patch

obsolete

>From bbaf63fe6924e3fc8fbad866ae46dc13858e7c59 Mon Sep 17 00:00:00 2001
>From: Volker Lendecke <vl@samba.org>
>Date: Sat, 16 Jan 2010 13:31:44 +0100
>Subject: [PATCH] s3: Fix a crash in libsmbclient used against the OpenSolaris CIFS server
>
>A user has sent me a sniff where the OpenSolaris CIFS server returns "32" in
>totalentries, but the array in ctr only contains 15 entries. Look at the right
>delimiter for walking the array.
>---
> source/libsmb/libsmb_dir.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/source/libsmb/libsmb_dir.c b/source/libsmb/libsmb_dir.c
>index d238ab9..9b06ca5 100644
>--- a/source/libsmb/libsmb_dir.c
>+++ b/source/libsmb/libsmb_dir.c
>@@ -303,7 +303,7 @@ net_share_enum_rpc(struct cli_state *cli,
>         }
> 
>         /* For each returned entry... */
>-        for (i = 0; i < total_entries; i++) {
>+        for (i = 0; i < info_ctr.ctr.ctr1->count; i++) {
> 
>                 /* pull out the share name */
> 		fstrcpy(name, info_ctr.ctr.ctr1->array[i].name);
>-- 
>1.6.0.4
>

Actions: View

Attachments on bug 7046: 5196 | 5197 | 5198