Attachment 5113 Details for Bug 7014 – Backport to 3.3.x

[patch] Backport to 3.3.x

0001-Prevent-NULL-dereference-if-group-has-no-members.patch (text/plain), 1.10 KB, created by Jeremy Allison on 2009-12-30 20:21:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jeremy Allison

Created: 2009-12-30 20:21:48 UTC

Size: 1.10 KB

patch

obsolete

>From 84277b8e6667547808069dc4e0171a135e105736 Mon Sep 17 00:00:00 2001
>From: Jim McDonough <jmcd@samba.org>
>Date: Wed, 30 Dec 2009 18:19:46 -0800
>Subject: [PATCH] Prevent NULL dereference if group has no members
>
>---
> source/winbindd/winbindd_rpc.c |    8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/source/winbindd/winbindd_rpc.c b/source/winbindd/winbindd_rpc.c
>index db43559..459a844 100644
>--- a/source/winbindd/winbindd_rpc.c
>+++ b/source/winbindd/winbindd_rpc.c
>@@ -787,16 +787,16 @@ static NTSTATUS lookup_groupmem(struct winbindd_domain *domain,
>         if (!NT_STATUS_IS_OK(result))
> 		return result;
> 
>-	*num_names = rids->count;
>-	rid_mem = rids->rids;
>-
>-	if (!*num_names) {
>+	if (!rids || !rids->count) {
> 		names = NULL;
> 		name_types = NULL;
> 		sid_mem = NULL;
> 		return NT_STATUS_OK;
> 	}
> 
>+	*num_names = rids->count;
>+	rid_mem = rids->rids;
>+
>         /* Step #2: Convert list of rids into list of usernames.  Do this
>            in bunches of ~1000 to avoid crashing NT4.  It looks like there
>            is a buffer overflow or something like that lurking around
>-- 
>1.6.3.3
>

Flags:

vl: review+

Actions: View

Attachments on bug 7014: 5112 | 5113