The Samba-Bugzilla – Attachment 5096 Details for
Bug 6939
mangling method = hash breaks long filenames
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
git-am format patch for 3.4.4.
0001-Fix-bug-6939-mangling-method-hash-breaks-long-f.patch (text/plain), 1.03 KB, created by
Jeremy Allison
on 2009-12-17 18:23:34 UTC
(
hide
)
Description:
git-am format patch for 3.4.4.
Filename:
MIME Type:
Creator:
Jeremy Allison
Created:
2009-12-17 18:23:34 UTC
Size:
1.03 KB
patch
obsolete
>From 00da7a4e5767c8b8be3391ba7cf7412fb820aa24 Mon Sep 17 00:00:00 2001 >From: Jeremy Allison <jra@samba.org> >Date: Thu, 17 Dec 2009 16:21:46 -0800 >Subject: [PATCH] Fix bug #6939 - mangling method = hash breaks long filenames. > >We were returning the wrong sense of the bool. must_mangle() >has to return !NT_STATUS_IS_OK, not NT_STATUS_IS_OK. > >Jeremy. >--- > source3/smbd/mangle_hash.c | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletions(-) > >diff --git a/source3/smbd/mangle_hash.c b/source3/smbd/mangle_hash.c >index 96fe4d2..b582d19 100644 >--- a/source3/smbd/mangle_hash.c >+++ b/source3/smbd/mangle_hash.c >@@ -612,7 +612,10 @@ static bool must_mangle(const char *name, > } > status = is_valid_name(name_ucs2, False, False); > SAFE_FREE(name_ucs2); >- return NT_STATUS_IS_OK(status); >+ /* We return true if we *must* mangle, so if it's >+ * a valid name (status == OK) then we must return >+ * false. Bug #6939. */ >+ return !NT_STATUS_IS_OK(status); > } > > /***************************************************************************** >-- >1.5.4.3 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Raw
Flags:
bjacke
:
review+
Actions:
View
Attachments on
bug 6939
: 5096 |
5097