Attachment 4750 Details for Bug 6763 – Samba 3.3.7 patch

[patch] Samba 3.3.7 patch

samba-3-3-7.patch (text/plain), 1.41 KB, created by Jeremy Allison on 2009-09-25 20:13:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jeremy Allison

Created: 2009-09-25 20:13:33 UTC

Size: 1.41 KB

patch

obsolete

>diff --git a/source/param/loadparm.c b/source/param/loadparm.c
>index 3908aef..491264e 100644
>--- a/source/param/loadparm.c
>+++ b/source/param/loadparm.c
>@@ -5875,6 +5875,11 @@ bool lp_add_home(const char *pszHomename, int iDefaultService,
> {
> 	int i;
> 
>+	if (pszHomename == NULL || user == NULL || pszHomedir == NULL ||
>+			pszHomedir[0] == '\0') {
>+		return false;
>+	}
>+
> 	i = add_a_service(ServicePtrs[iDefaultService], pszHomename);
> 
> 	if (i < 0)
>@@ -7848,7 +7853,7 @@ static void lp_add_auto_services(char *str)
> 
> 		home = get_user_home_dir(talloc_tos(), p);
> 
>-		if (home && homes >= 0)
>+		if (home && home[0] && homes >= 0)
> 			lp_add_home(p, homes, p, home);
> 
> 		TALLOC_FREE(home);
>diff --git a/source/smbd/service.c b/source/smbd/service.c
>index 4724dd7..2a1ef20 100644
>--- a/source/smbd/service.c
>+++ b/source/smbd/service.c
>@@ -55,6 +55,10 @@ bool set_conn_connectpath(connection_struct *conn, const char *connectpath)
> 	const char *s = connectpath;
>         bool start_of_name_component = true;
> 
>+	if (connectpath == NULL || connectpath[0] == '\0') {
>+		return false;
>+	}
>+
> 	destname = SMB_STRDUP(connectpath);
> 	if (!destname) {
> 		return false;
>@@ -331,7 +335,7 @@ int add_home_service(const char *service, const char *username, const char *home
> {
> 	int iHomeService;
> 
>-	if (!service || !homedir)
>+	if (!service || !homedir || homedir[0] == '\0')
> 		return -1;
> 
> 	if ((iHomeService = lp_servicenumber(HOMES_NAME)) < 0) {

Actions: View

Attachments on bug 6763: 4748 | 4749 | 4750 | 4751