Attachment 4639 Details for Bug 6651 – Next part of the fix (for master)

[patch] Next part of the fix (for master)

0001-Another-part-of-the-fix-for-bug-6651-smbd-SIGSEGV.patch (text/plain), 1.11 KB, created by Jeremy Allison on 2009-09-03 09:58:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jeremy Allison

Created: 2009-09-03 09:58:30 UTC

Size: 1.11 KB

patch

obsolete

>From c97698e762b1ea8d7133f04ae822225676a6f135 Mon Sep 17 00:00:00 2001
>From: Jeremy Allison <jra@samba.org>
>Date: Thu, 3 Sep 2009 07:38:21 -0700
>Subject: [PATCH] Another part of the fix for bug 6651 - smbd SIGSEGV when breaking oplocks.
> SA_INFO_QUEUE_COUNT *MUST* be a power of 2, in order for the ring buffer
> wrap to work correctly at the 32 bit boundary. Thanks to Petr
> Vandrovec <petr@vandrovec.name> for this.
>
>---
> lib/tevent/tevent_signal.c |    8 ++++++--
> 1 files changed, 6 insertions(+), 2 deletions(-)
>
>diff --git a/lib/tevent/tevent_signal.c b/lib/tevent/tevent_signal.c
>index b329f8c..ef9c0cf 100644
>--- a/lib/tevent/tevent_signal.c
>+++ b/lib/tevent/tevent_signal.c
>@@ -32,8 +32,12 @@
> 
> #define NUM_SIGNALS 64
> 
>-/* maximum number of SA_SIGINFO signals to hold in the queue */
>-#define SA_INFO_QUEUE_COUNT 100
>+/* maximum number of SA_SIGINFO signals to hold in the queue.
>+  NB. This *MUST* be a power of 2, in order for the ring buffer
>+  wrap to work correctly. Thanks to Petr Vandrovec <petr@vandrovec.name>
>+  for this. */
>+
>+#define SA_INFO_QUEUE_COUNT 64
> 
> struct sigcounter {
> 	uint32_t count;
>-- 
>1.6.0.4
>

Actions: View

Attachments on bug 6651: 4580 | 4585 | 4586 | 4595 | 4639 | 4640 | 4647