Attachment 4579 Details for Bug 6638 – Patch for 3.4.1.

[patch] Patch for 3.4.1.

0001-Fix-bug-6638-ADS-Domain-Member-Computer-Mgr-can-n.patch (text/plain), 2.22 KB, created by Jeremy Allison on 2009-08-20 13:13:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jeremy Allison

Created: 2009-08-20 13:13:54 UTC

Size: 2.22 KB

patch

obsolete

>From 610482bb153a7d19932ecb63a1e10932c0eac81e Mon Sep 17 00:00:00 2001
>From: Jeremy Allison <jra@samba.org>
>Date: Thu, 20 Aug 2009 11:12:22 -0700
>Subject: [PATCH] Fix bug 6638 - ADS Domain Member: Computer Mgr can not set share ACLs
> Add good error message for share modification denial.
> Jeremy.
>
>---
> source3/rpc_server/srv_srvsvc_nt.c |   22 +++++++++++++++++++---
> 1 files changed, 19 insertions(+), 3 deletions(-)
>
>diff --git a/source3/rpc_server/srv_srvsvc_nt.c b/source3/rpc_server/srv_srvsvc_nt.c
>index 056236f..d8c0ce6 100644
>--- a/source3/rpc_server/srv_srvsvc_nt.c
>+++ b/source3/rpc_server/srv_srvsvc_nt.c
>@@ -1512,6 +1512,9 @@ WERROR _srvsvc_NetShareSetInfo(pipes_struct *p,
> 		|| ( lp_enable_asu_support() && strequal(share_name,"ADMIN$") )
> 		|| strequal(share_name,"global") )
> 	{
>+		DEBUG(5,("_srvsvc_NetShareSetInfo: share %s cannot be "
>+			"modified by a remote user.\n",
>+			share_name ));
> 		return WERR_ACCESS_DENIED;
> 	}
> 
>@@ -1529,8 +1532,14 @@ WERROR _srvsvc_NetShareSetInfo(pipes_struct *p,
> 
> 	/* fail out now if you are not root and not a disk op */
> 
>-	if ( p->server_info->utok.uid != sec_initial_uid() && !is_disk_op )
>+	if ( p->server_info->utok.uid != sec_initial_uid() && !is_disk_op ) {
>+		DEBUG(2,("_srvsvc_NetShareSetInfo: uid %u doesn't have the "
>+			"SeDiskOperatorPrivilege privilege needed to modify "
>+			"share %s\n",
>+			(unsigned int)p->server_info->utok.uid,
>+			share_name ));
> 		return WERR_ACCESS_DENIED;
>+	}
> 
> 	switch (r->in.level) {
> 	case 1:
>@@ -1597,16 +1606,23 @@ WERROR _srvsvc_NetShareSetInfo(pipes_struct *p,
> 	}
> 
> 	/* We can only modify disk shares. */
>-	if (type != STYPE_DISKTREE)
>+	if (type != STYPE_DISKTREE) {
>+		DEBUG(5,("_srvsvc_NetShareSetInfo: share %s is not a "
>+			"disk share\n",
>+			share_name ));
> 		return WERR_ACCESS_DENIED;
>+	}
> 
> 	if (comment == NULL) {
> 		return WERR_NOMEM;
> 	}
> 
> 	/* Check if the pathname is valid. */
>-	if (!(path = valid_share_pathname(p->mem_ctx, pathname )))
>+	if (!(path = valid_share_pathname(p->mem_ctx, pathname ))) {
>+		DEBUG(5,("_srvsvc_NetShareSetInfo: invalid pathname %s\n",
>+			pathname ));
> 		return WERR_OBJECT_PATH_INVALID;
>+	}
> 
> 	/* Ensure share name, pathname and comment don't contain '"' characters. */
> 	string_replace(share_name, '"', ' ');
>-- 
>1.5.4.3
>

Actions: View

Attachments on bug 6638: 4556 | 4557 | 4558 | 4579